Skip to content

Add normalizer to opensearch mapper to help implement case insensitiv… - #1347

Merged
svogt0511 merged 9 commits into
masterfrom
pb306-case-sensitivity
Sep 11, 2025
Merged

svogt0511 merged 9 commits into
masterfrom
pb306-case-sensitivity

Conversation

@svogt0511

@svogt0511 svogt0511 commented Jun 12, 2025 •

Copy link
Copy Markdown
Contributor

…e search for doi and id fields.

Purpose

closes: datacite/datacite#2115
closes: datacite/product-backlog#306

Approach

Follow the same approach as was used for implementing case insensitive search for the uid field.

Requires a re-index before this can be closed.

Open Questions and Pre-Merge TODOs

  • Needs a couple of tests.
  • Needs re-index after this is merged. Waiting on another bug fix so we can reduce the number of re-index operations.

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@svogt0511
svogt0511 requested a review from jrhoads June 12, 2025 21:46
@svogt0511 svogt0511 self-assigned this Jun 12, 2025

@jrhoads jrhoads left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I agree. A test or two with different capitalizations for query values would be good

@jrhoads

jrhoads commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

Awesome. I see you added the tests. Were there any VCR cassettes created locally when you ran the tests that should be added to the repository?

@svogt0511

Copy link
Copy Markdown
Contributor Author

Awesome. I see you added the tests. Were there any VCR cassettes created locally when you ran the tests that should be added to the repository?

No vcr cassettes needed for the new tests.

@svogt0511
svogt0511 merged commit ac82b57 into master Sep 11, 2025
18 checks passed
@svogt0511
svogt0511 deleted the pb306-case-sensitivity branch September 11, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOI id and doi are case-sensitive in REST API queries

2 participants