Repository navigation
Add normalizer to opensearch mapper to help implement case insensitiv… - #1347
Merged
Merged
Conversation
…e search for doi and id fields.
jrhoads
approved these changes
Jun 13, 2025
jrhoads
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
I agree. A test or two with different capitalizations for query values would be good
Contributor
|
Awesome. I see you added the tests. Were there any VCR cassettes created locally when you ran the tests that should be added to the repository? |
jrhoads
approved these changes
Jun 17, 2025
jrhoads
approved these changes
Jun 20, 2025
Contributor
Author
No vcr cassettes needed for the new tests. |
jrhoads
approved these changes
Jun 30, 2025
jrhoads
approved these changes
Jul 30, 2025
jrhoads
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e search for doi and id fields.
Purpose
closes: datacite/datacite#2115
closes: datacite/product-backlog#306
Approach
Follow the same approach as was used for implementing case insensitive search for the uid field.
Requires a re-index before this can be closed.
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: