Skip to content

Consolidated DeltaSolver and KeyValueStoreSolver into DefaultSolver#46

Draft
tombonfert wants to merge 2 commits into
mainfrom
feature/consolidate_solvers
Draft

Consolidated DeltaSolver and KeyValueStoreSolver into DefaultSolver#46
tombonfert wants to merge 2 commits into
mainfrom
feature/consolidate_solvers

Conversation

@tombonfert

@tombonfert tombonfert commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Consolidated the implementation of DeltaSolver and KeyValueStoreSolver into the new DefaultSolver class
  • Replaced instances of DeltaSolver and KeyValueStoreSolver with DefaultSolver across documentation and configuration files to reflect the new unified solver approach.
  • Updated the pydoc-markdown configuration to remove deprecated solver references and clarify the usage of DefaultSolver.
  • Enhanced the query engine documentation to explain the behavior of DefaultSolver in relation to silver-layer table configurations.
  • Removed DeltaSolver API documentation and added DefaultSolver API documentation to ensure consistency and clarity in the codebase.

Changes

Test Plan

  • Unit tests added/updated
  • Manual testing completed
  • Documentation updated (if applicable)

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No new linter warnings introduced

- Replaced instances of DeltaSolver and KeyValueStoreSolver with DefaultSolver across documentation and configuration files to reflect the new unified solver approach.
- Updated the pydoc-markdown configuration to remove deprecated solver references and clarify the usage of DefaultSolver.
- Enhanced the query engine documentation to explain the behavior of DefaultSolver in relation to silver-layer table configurations.
- Removed DeltaSolver API documentation and added DefaultSolver API documentation to ensure consistency and clarity in the codebase.
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.88%. Comparing base (fcd65ca) to head (2f6a8db).

Files with missing lines Patch % Lines
src/impulse_reporting/core/report.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   86.35%   86.88%   +0.53%     
==========================================
  Files          52       51       -1     
  Lines        4229     4118     -111     
  Branches      507      492      -15     
==========================================
- Hits         3652     3578      -74     
+ Misses        479      448      -31     
+ Partials       98       92       -6     
Files with missing lines Coverage Δ
...mpulse_query_engine/analyze/query/query_builder.py 87.77% <ø> (ø)
...ery_engine/analyze/query/solvers/default_solver.py 94.26% <100.00%> (ø)
...query_engine/analyze/query/solvers/query_solver.py 87.09% <ø> (ø)
...query_engine/analyze/query/solvers/series_cache.py 80.00% <ø> (ø)
...uery_engine/analyze/query/solvers/solver_config.py 100.00% <ø> (ø)
src/impulse_reporting/config/config_parser.py 97.14% <100.00%> (+0.02%) ⬆️
src/impulse_reporting/core/report.py 89.06% <66.66%> (-0.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant