Skip to content

Add PointsInTimeSeries class and integrate with SampleSeries#45

Draft
tombonfert wants to merge 2 commits into
mainfrom
feature/points_in_time_series
Draft

Add PointsInTimeSeries class and integrate with SampleSeries#45
tombonfert wants to merge 2 commits into
mainfrom
feature/points_in_time_series

Conversation

@tombonfert

Copy link
Copy Markdown
Collaborator

Summary

  • Introduced the PointsInTimeSeries class to represent time series data with values defined at specific timestamps.
  • Updated the SampleSeries class to support filtering based on PointsInTime, returning a PointsInTimeSeries when applicable.
  • Enhanced the init.py file to include the new PointsInTimeSeries class.
  • Added unit tests for PointsInTimeSeries and updated existing tests to validate new functionality.
  • Ensured compatibility with existing series types and improved overall functionality in time series operations.

Changes

Test Plan

  • Unit tests added/updated
  • Manual testing completed
  • Documentation updated (if applicable)

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No new linter warnings introduced

- Introduced the PointsInTimeSeries class to represent time series data with values defined at specific timestamps.
- Updated the SampleSeries class to support filtering based on PointsInTime, returning a PointsInTimeSeries when applicable.
- Enhanced the __init__.py file to include the new PointsInTimeSeries class.
- Added unit tests for PointsInTimeSeries and updated existing tests to validate new functionality.
- Ensured compatibility with existing series types and improved overall functionality in time series operations.
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.41104% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.54%. Comparing base (fcd65ca) to head (ba55240).

Files with missing lines Patch % Lines
...query_engine/model/series/points_in_time_series.py 91.02% 12 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   86.35%   86.54%   +0.18%     
==========================================
  Files          52       53       +1     
  Lines        4229     4391     +162     
  Branches      507      528      +21     
==========================================
+ Hits         3652     3800     +148     
- Misses        479      491      +12     
- Partials       98      100       +2     
Files with missing lines Coverage Δ
...impulse_query_engine/model/series/sample_series.py 84.66% <100.00%> (+0.21%) ⬆️
...query_engine/model/series/points_in_time_series.py 91.02% <91.02%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…Series

- Added a new documentation file for the Core Data Model, detailing the in-memory result classes and their interactions.
- Updated existing documentation for Aggregations and Events to adjust sidebar positions for better organization.
- Enhanced the TSAL documentation to clarify filtering methods and their return types, including the integration of PointsInTimeSeries.
- Updated the API sidebar to include the new PointsInTimeSeries reference, ensuring comprehensive access to all series types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant