Split airflow loader into a focused package - #54
Merged
Conversation
Move sources/airflow/loader.py (~4,300 lines) into a loader/ package along its existing seams (captures, ast_utils, schedule, dispatch, graph, visitor, dag_discovery, policy, activity_templates, taskflow, dbt, reconcile, lowering, api). Pure moves: public entry points unchanged via a thin facade, single-owner constants imported rather than copied. Addresses databricks-field-eng/flowx#36.
1 task
ghanse
approved these changes
Sep 10, 2026
Collaborator
There was a problem hiding this comment.
Added #67 to track future decomposition of _DagVisitor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the ~4,300-line
src/flowx/sources/airflow/loader.pyinto a focusedloader/package along its existing seams, as pure moves with no behavior change. Addresses databricks-field-eng/flowx#36.Package modules:
captures,ast_utils,schedule,dispatch,graph,visitor,dag_discovery,policy,activity_templates,taskflow,dbt,reconcile,lowering,api, plus a thin__init__facade re-exporting the five public entry points (load_airflow_dag,load_airflow_dags,load_pipelines,discover_dags,detect_hosts). Public imports are unchanged; single-owner constants (e.g. the_UNRESOLVEDidentity sentinel) are imported rather than copied;_DagVisitor,_load_airflow_module, and_reconcile_pipelinemove intact, leaving their internal decomposition as separate follow-ups.Verification (pure move / no behavior change)
golden_pipeline_dag,orders_analytics_dag).reconcile._reconcile_pipeline(...)) that preserves the reconciliation tests' monkeypatch.