Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nilts/pubspec.yaml
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Deprecated API pattern in use - analysisRule getter

The release notes for analyzer_testing v0.1.7 state: "Deprecate AnalysisRuleTest.analysisRule; instead of implementing this getter, set the rule field in the setUp method, before calling super.setUp."

All test files in this project use the deprecated pattern, for example in packages/nilts/test/unstable_enum_name_test.dart:114:

@override
String get analysisRule => UnstableEnumName.ruleName;

This is found in 19 test files. While deprecated APIs typically continue to work, upgrading to 0.1.10 will likely produce deprecation warnings during test runs. Consider updating to the new pattern (rule = MyRule() in setUp before super.setUp()) to stay current with the library's conventions.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ dev_dependencies:
very_good_analysis: 10.2.0

test: 1.31.0
analyzer_testing: 0.1.9
analyzer_testing: 0.2.6
2 changes: 1 addition & 1 deletion packages/nilts_clock/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ dev_dependencies:
very_good_analysis: 10.2.0

test: 1.31.0
analyzer_testing: 0.1.9
analyzer_testing: 0.2.6
2 changes: 1 addition & 1 deletion packages/nilts_flutter_hooks/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ dev_dependencies:
very_good_analysis: 10.2.0

test: 1.31.0
analyzer_testing: 0.1.9
analyzer_testing: 0.2.6
Loading