ci: removed multiple unused CI scripts - #7641
Conversation
Nothing references ci/dash/build_depends.sh: the depends build moved into .github/workflows/build-depends.yml, which runs `make -C depends` inline.
Dash CI runs on GitHub Actions via ci/dash/*.sh, which selects a ci/test/00_setup_env*.sh configuration through ci/dash/matrix.sh. The staged Bitcoin Core pipeline was never wired into it: ci/test_run_all.sh sources 04_install.sh and 05_before_script.sh and then stops, because the 06_script_*.sh stages were never adopted, so it sets up an environment without running a single test. Nothing references these files except ci/README.md, yet they keep absorbing backport conflicts and maintenance that has no effect on CI. Same reasoning as the earlier .cirrus.yml (dashpay#6704) removal Also removed as fully unreferenced: ci/test/wrap-wine.sh ci/README.md is trimmed accordingly; its removed examples also cited ci/test/00_setup_env_arm.sh, a file that does not exist.
|
✅ Final review complete — no blockers (commit e9b40c4) |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (5)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe CI README now documents configuration files selected by Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes unused CI scripts and updates the CI documentation without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Codex/Sol only (Phase 2 disabled)
At exact head e9b40c4, the PR cleanly removes the obsolete staged CI pipeline and superseded depends helper while updating ci/README.md to describe the active GitHub Actions setup. The active workflows source ci/dash/matrix.sh, build depends directly, and retain no references to the deleted entry points, so no in-scope defect was found.
Source: codex-general, codex-dash-core-commit-history, and codex-backport-reviewer (their exact backend model IDs are not exposed in the supplied evidence); final verifier backend model grok-4.5. Orchestration-only: openclaw-agent/cliproxy/gpt-5.6-sol (not reviewer evidence).
Validated zero-blocker Codex/Sol precheck evidence was promoted to final because Phase 2 (Sonnet/Opus) is temporarily disabled. This is Codex/Sol-only final validation, not Codex + Sonnet/Opus coverage.
Review provenance
- Codex reviewers:
gpt-5.6-sol— general (completed),gpt-5.6-sol— dash-core-commit-history (completed),gpt-5.6-sol— backport-reviewer (completed) - Verifier:
gpt-5.6-sol— verifier - Sonnet/Opus: not run (Phase 2 disabled — temporary Codex/Sol-only final)
- Secondary pass: disabled (
temporary_phase2_sonnet_disable)
Potential PR merge conflictsThis is advisory only. It does not block CI, but it marks PRs that will likely need a rebase depending on merge order. If these PRs merge firstThis PR will likely need a rebase:
|
Issue being fixed or feature implemented
Some scripts for "CI" exists as they have been backported from Bitcoin Core but they are completely irrelevant, in non-working condition.
Beside extra conflicts to resolve for Dash Core when backporting changes from Bitcoin Core, they also masks real changes that should be done during backports but in other files, such as
ci/dash/build_src.shorci/dash/lint-tidy.sh.What was done?
Removed:
Updated
ci/README.mdaccordingly current status.How Has This Been Tested?
N/A
Breaking Changes
N/A
Checklist: