EXR Add Compression HTJ2K#20777
Conversation
|
We require OpenEXR 3.0 or above. So either this is made conditional depending on the OpenEXR version or we bump OpenEXR minimal version required if 3.4 is widely available. |
Not the case yet unfortunately, looks like it won't even be in the upcoming Ubuntu 26.04: https://repology.org/project/openexr/versions |
|
Thanks @kmilos. So the only option for now is to make this code optional (depending on the runtime version used) or to wait for 3.4 to be widely available. |
This code should be conditional even when 3.4 is widely available. Even then, someone could build darktable with an older version of the library. If the code doesn't check for support for these encoders and they are missing from the library, there will be a crash. @TodicaIonut Are you going to improve this PR or should I take over? |
|
It seems that the author of the PR is too shy and there will be no response. @TurboGit I suggest closing this PR. The idea itself is good, we can add new compression types, but it is necessary to check that they are supported. I'll do a PR tomorrow with a crash-safe code. |
|
Thanks @victoryforce ! |
OpenEXR requires v3.4