Skip to content

EXR Add Compression HTJ2K#20777

Closed
TodicaIonut wants to merge 1 commit intodarktable-org:masterfrom
TodicaIonut:patch-1
Closed

EXR Add Compression HTJ2K#20777
TodicaIonut wants to merge 1 commit intodarktable-org:masterfrom
TodicaIonut:patch-1

Conversation

@TodicaIonut
Copy link
Copy Markdown

OpenEXR requires v3.4

@TurboGit
Copy link
Copy Markdown
Member

We require OpenEXR 3.0 or above. So either this is made conditional depending on the OpenEXR version or we bump OpenEXR minimal version required if 3.4 is widely available.

@kmilos
Copy link
Copy Markdown
Contributor

kmilos commented Apr 10, 2026

if 3.4 is widely available

Not the case yet unfortunately, looks like it won't even be in the upcoming Ubuntu 26.04: https://repology.org/project/openexr/versions

@TurboGit
Copy link
Copy Markdown
Member

Thanks @kmilos. So the only option for now is to make this code optional (depending on the runtime version used) or to wait for 3.4 to be widely available.

@TurboGit TurboGit marked this pull request as draft April 10, 2026 15:33
@TurboGit TurboGit added feature: enhancement current features to improve priority: low core features work as expected, only secondary/optional features don't scope: software support wiring external libs and software: LittleCMS, colord, G'MIC, enfuse/enblend, etc. release notes: pending depends: external lib labels Apr 10, 2026
@victoryforce
Copy link
Copy Markdown
Collaborator

So the only option for now is to make this code optional (depending on the runtime version used) or to wait for 3.4 to be widely available.

This code should be conditional even when 3.4 is widely available. Even then, someone could build darktable with an older version of the library. If the code doesn't check for support for these encoders and they are missing from the library, there will be a crash.

@TodicaIonut Are you going to improve this PR or should I take over?

@victoryforce
Copy link
Copy Markdown
Collaborator

It seems that the author of the PR is too shy and there will be no response.

@TurboGit I suggest closing this PR.

The idea itself is good, we can add new compression types, but it is necessary to check that they are supported. I'll do a PR tomorrow with a crash-safe code.

@TurboGit TurboGit closed this Apr 21, 2026
@TurboGit
Copy link
Copy Markdown
Member

Thanks @victoryforce !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

depends: external lib feature: enhancement current features to improve priority: low core features work as expected, only secondary/optional features don't release notes: pending scope: software support wiring external libs and software: LittleCMS, colord, G'MIC, enfuse/enblend, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants