fix(durabletask): detect shutdown and break gRPC worker loop

[javier-aliaga]

Description

Summary

• Fix DurableTaskGrpcWorker.startAndBlock() loop not exiting when close()/stop() is called while the gRPC stream is blocking
• The while (true) loop only broke on InterruptedException during the 5s retry sleep — a CANCELLED from channel shutdown was logged but retried indefinitely

Changes

durabletask-client — DurableTaskGrpcWorker

• Replace while (true) with while (!isNormalShutdown && !Thread.currentThread().isInterrupted()) to check shutdown signals each iteration
• Break out of the retry path when CANCELLED is received during a normal shutdown, avoiding a stale 5s sleep cycle
• Re-set the thread interrupt flag before breaking on InterruptedException to preserve the interrupt contract for upstream callers

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1728

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Extended the documentation

[Copilot]

Pull request overview

Fixes DurableTaskGrpcWorker.startAndBlock() not terminating promptly during shutdown when the gRPC getWorkItems() stream is blocking, aligning behavior with issue #1728 expectations.

Changes:

• Replaces the infinite worker loop with a loop that checks isNormalShutdown and thread interrupt status.
• Exits the retry path on CANCELLED during normal shutdown and preserves interrupt status when sleep is interrupted.

Comments suppressed due to low confidence (1)

durabletask-client/src/main/java/io/dapr/durabletask/DurableTaskGrpcWorker.java:179

• The outer loop now checks isNormalShutdown, but the worker can still remain inside the inner while (workItemStream.hasNext()) and keep pulling/dispatching work items after shutdown has been requested. This is especially problematic because close() shuts down workerPool before the gRPC channel is closed, so workerPool.submit(...) can start throwing RejectedExecutionException (uncaught) during shutdown. Consider checking isNormalShutdown/Thread.interrupted() inside the work-item loop and breaking out (or short-circuiting submissions) as soon as shutdown is requested, to avoid dispatching new work during shutdown and to exit promptly.

    while (!this.isNormalShutdown && !Thread.currentThread().isInterrupted()) {
      try {
        OrchestratorService.GetWorkItemsRequest getWorkItemsRequest = OrchestratorService.GetWorkItemsRequest
            .newBuilder().build();
        Iterator<OrchestratorService.WorkItem> workItemStream = this.sidecarClient.getWorkItems(getWorkItemsRequest);
        while (workItemStream.hasNext()) {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

This PR fixes DurableTaskGrpcWorker.startAndBlock() not exiting promptly during shutdown by making the worker loop aware of normal shutdown and thread interrupts, and by avoiding retries when gRPC disconnects due to shutdown.

Changes:

• Update the worker loop condition to stop on normal shutdown and on thread interrupt.
• Break out of the retry path when gRPC returns CANCELLED during a normal shutdown, and preserve interrupt status when catching InterruptedException.
• Add unit tests intended to validate shutdown/interrupt behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.

File	Description
durabletask-client/src/main/java/io/dapr/durabletask/DurableTaskGrpcWorker.java	Adjusts the worker loop to exit on shutdown/interrupt and handles CANCELLED during shutdown.
durabletask-client/src/test/java/io/dapr/durabletask/DurableTaskGrpcWorkerShutdownTest.java	Adds tests for prompt termination on close() and on interrupt.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.90%. Comparing base (e5cf3f3) to head (944bf24).

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1727   +/-   ##
=========================================
  Coverage     72.90%   72.90%           
  Complexity     2257     2257           
=========================================
  Files           242      242           
  Lines          7415     7415           
  Branches        738      738           
=========================================
  Hits           5406     5406           
  Misses         1648     1648           
  Partials        361      361           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.