Repository navigation
Trim whitespace before JSON sniffing. - #78
Merged
Merged
Conversation
danmoz
approved these changes
Oct 15, 2026
Co-authored-by: danmoz <danmoz@users.noreply.github.com>
danmoz
force-pushed
the
opencode/issue38-20260905203831
branch
from
October 15, 2026 00:18
5983139 to
f9c3e96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed. The sniffing guard in
req_resp.go:61now trims leading whitespace before checking for the JSON{byte, so a whitespace-prefixedHTTPJSON-REPenvelope is correctly decoded instead of falling through to a bare 200 body. Added a test for this case; all tests, build, and vet pass.Closes #38
opencode session | github run