Skip to content

[measure] core vitest 6 shards - #13

Open
danielmlr wants to merge 10 commits into
mainfrom
daniel/ci-vitest-shards
Open

danielmlr wants to merge 10 commits into
mainfrom
daniel/ci-vitest-shards

Conversation

@danielmlr

Copy link
Copy Markdown
Owner

Measurement run on the fork for the upstream draft; not for merging.

khoinguyenpham04 and others added 8 commits October 27, 2026 23:04
…tions (emdash-cms#4435)

The Plugins page showed "1 plugins" because the count was a plain
template message. It now uses plural(), so each locale picks its own
plural form.

The SEO settings section title joined the "Google Verification" and
"Bing Verification" translations with " / ", which translators could
not reorder or rephrase. It is now one message, "Search Engine
Verification", in the same Title Case as the page's other sections.
…s#4433)

* fix(admin): show the admin not-found page for unknown URLs

The catch-all route used `path: "*"`, which TanStack Router treats as a
literal segment rather than a splat. Unknown admin URLs matched no route,
so the router rendered its default "Not Found" text at the root: outside
the admin shell for top-level paths such as /does-not-exist, and inside
it for nested ones such as /settings/nope. Use the `$` splat so every
unknown admin URL renders NotFoundPage inside the shell.

Also translate the "Collection not found" message.

* docs: limit the not-found changeset to signed-in users

Signed-out visitors are still redirected to the login page, and unknown
URLs under /login, /signup and /invite/accept show "Not authenticated",
so the entry no longer promises the not-found page at every unknown
admin URL.
…#4434)

The trash buttons on a single menu item and a single widget deleted on
one click, with no confirmation and no undo, while deleting a whole menu
or widget area already asked first. Both now open ConfirmDialog, which
names the item, and the delete runs only after it is confirmed. A failed
delete keeps the dialog open with the error instead of showing a toast.

The MenuEditor test that pinned the one-click delete is replaced, and the
two e2e tests that deleted an item or widget with one click now confirm.
… card (emdash-cms#4096)

"Hide from navigation" removes a collection's sidebar entry, command
palette link and dashboard quick action so that a plugin which owns the
collection can keep editors out of it. The dashboard's Content card
still listed every hidden collection with a link into it, so the
dashboard kept steering editors where the sidebar does not.

The card now skips collections whose manifest entry is hidden, the same
check the quick actions make. Collections missing from the manifest
still render, and hidden collections still count toward the dashboard
totals and still appear in Recent Activity. The docs, type comments and
the toggle's help text now name the Content card alongside the other
three surfaces.

Co-authored-by: Daniel Mueller <daniel@eisbachcode.de>
… takes

Vitest's --shard deals test files out by count, so shard 4 of 4 ran
431 seconds of tests while shard 3 ran 264, and the core unit tests are
the next longest job once the E2E shards are even. A sequencer now packs
the files by the durations recorded in tests/shard-times.json, and six
shards replace four. Each shard uploads its JSON report so the times can
be refreshed with .github/scripts/vitest-shard.mjs --record.
@github-actions github-actions Bot added the review/needs-review No maintainer or bot review yet label Oct 28, 2026
…able on ties

Vitest's JSON report spans a file from its first test to its last, so
--record would have dropped beforeAll and afterAll time and the first
refresh would have underweighted files that build in a hook. A reporter
now records each file's import, setup and run time from Vitest's own
diagnostics. The input-order test covers tied weights, since most
recorded files weigh one second, and the 25 render tests this config
excludes leave the times file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review/needs-review No maintainer or bot review yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants