Repository navigation
fix(cli): fold five Python commands into shared separator helper - #1
Open
Protocol-zero-0 wants to merge 1 commit into
Open
Protocol-zero-0 wants to merge 1 commit into
Protocol-zero-0 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration update (2026-11-01): KuSh's review of #4768 recommends folding this supplement into the shared entry point. KuSh reports running this exact head (42bb2ec): real pytest
-- -k.pymatches native, all five arm mutations are caught, and fmt/clippy/tests pass (5220 tests). These are the maintainer's independent results; the validation below records our original runs.The parent PR remains open with three blocking findings in that review (phpstan option placement, non-UTF-8 argv[0], and coverage of the args_os read). This supplement retains its five-Python-arm scope. Once incorporated, the parent can use
Fixes #4753, as KuSh suggests; incorporation and merge are still pending.This supplement to rtk-ai#4768 folds
Pytest | Mypy | Pip | Uv | Sqlfluffintorestore_leading_double_dash, as discussed in that PR and rtk-ai#4753. The shared helper restores the clap-consumed leading separator before dispatch, so arguments such aspytest -- -kremain positional instead of selecting tests.The patch adds the existing five Python process regressions alongside the helper change. It targets the source branch of rtk-ai#4768; it is intended to be incorporated into that PR.
Validation on Linux: