Skip to content

fix(cli): fold five Python commands into shared separator helper - #1

Open
Protocol-zero-0 wants to merge 1 commit into
danieldutu:fix/cli-leading-double-dashfrom
Protocol-zero-0:fix/python-arms-on-4768
Open

Protocol-zero-0 wants to merge 1 commit into
danieldutu:fix/cli-leading-double-dashfrom
Protocol-zero-0:fix/python-arms-on-4768

Conversation

@Protocol-zero-0

@Protocol-zero-0 Protocol-zero-0 commented Oct 30, 2026 •

Copy link
Copy Markdown

Integration update (2026-11-01): KuSh's review of #4768 recommends folding this supplement into the shared entry point. KuSh reports running this exact head (42bb2ec): real pytest -- -k.py matches native, all five arm mutations are caught, and fmt/clippy/tests pass (5220 tests). These are the maintainer's independent results; the validation below records our original runs.

The parent PR remains open with three blocking findings in that review (phpstan option placement, non-UTF-8 argv[0], and coverage of the args_os read). This supplement retains its five-Python-arm scope. Once incorporated, the parent can use Fixes #4753, as KuSh suggests; incorporation and merge are still pending.

This supplement to rtk-ai#4768 folds Pytest | Mypy | Pip | Uv | Sqlfluff into restore_leading_double_dash, as discussed in that PR and rtk-ai#4753. The shared helper restores the clap-consumed leading separator before dispatch, so arguments such as pytest -- -k remain positional instead of selecting tests.

The patch adds the existing five Python process regressions alongside the helper change. It targets the source branch of rtk-ai#4768; it is intended to be incorporated into that PR.

Validation on Linux:

  • Five Python process regressions and three existing non-Python process tests pass; formatting and diff checks pass on this commit.
  • The same helper change on the same base was previously checked with pytest 9.0.3 and 9.1.1: 24 scenarios / 72 native, original-head and folded-head executions. The five regressions failed on the original head and passed with the change. All-target clippy passed in that trial.

Copilot AI balanced review requested due to automatic review settings October 30, 2026 01:15
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 261bcbbb-a652-4bbe-b084-00509825c750

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants