SSO config to skip 2FA on login#6833
Open
kowalski7cc wants to merge 1 commit intodani-garcia:mainfrom
Open
Conversation
Signed-off-by: Kowalski Dragon (kowalski7cc) <kowalski7cc@users.noreply.github.com>
Author
|
@BlackDex @dani-garcia is this an acceptable change? Hope you can review this pull 😃 |
Contributor
|
If we want to skip 2FA for SSO shouldn't this be done properly i.e. by requesting a specific |
Author
|
Well it could be a tri-state where you can skip always (as workaround or testing), automatically (acr level) or never (current behavior). To add the automatically I need to read a bit of documentation about the acr 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to skip 2FA on SSO, userful when an external IdP has already multiple 2FA options.
Tested on Web Vault, Chrome Extension and Android app.