Skip to content

deprecation for filters.eccentricity#1955

Open
joshqsumner wants to merge 4 commits into
mainfrom
deprecate_eccentricity_filter
Open

deprecation for filters.eccentricity#1955
joshqsumner wants to merge 4 commits into
mainfrom
deprecate_eccentricity_filter

Conversation

@joshqsumner

Copy link
Copy Markdown
Contributor

Describe your changes
Adding a deprecation warning to pcv.filters.eccentricity

Type of update
This is a minor update looking towards v5

Associated issues
None

Additional context
Planning to just use the pcv.filters.obj_props function going forward although we could have wrappers.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@deepsource-io

deepsource-io Bot commented Jun 29, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 3ffe3d8...f2fe2df on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Jun 29, 2026 4:38p.m. Review ↗
Code coverage Jun 29, 2026 4:38p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
100%
Python
100%
[✓ above threshold]
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant