Skip to content

Restores the time_lapse_video function#1951

Merged
nfahlgren merged 12 commits into
v5.0from
add-timelapse-back
Jun 30, 2026
Merged

Restores the time_lapse_video function#1951
nfahlgren merged 12 commits into
v5.0from
add-timelapse-back

Conversation

@nfahlgren

@nfahlgren nfahlgren commented Jun 24, 2026

Copy link
Copy Markdown
Member

Describe your changes
Our plan was to deprecate the pcv.visualize.time_lapse_video function because it required QT and that created conflicts with PlantCV add-on tools. Instead we were able to refactor the function to use imageio instead of OpenCV and restore the functionality without QT. This PR also updates the function inputs to remove the display parameter, which only prints out the filepath of the video but is provided by the user.

We might consider changing the output value. The function returns the frame size but I think it could instead not return anything, like pcv.print_image.

Type of update
Is this a: New feature or feature enhancement

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

It just prints the output filename and path, which is given by the user in the first place
@nfahlgren nfahlgren added this to the PlantCV v5.0 milestone Jun 24, 2026
@nfahlgren nfahlgren added enhancement Enhancements to existing features ready to review labels Jun 24, 2026
@deepsource-io

deepsource-io Bot commented Jun 24, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 4173f71...585e933 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Jun 30, 2026 8:19p.m. Review ↗
Code coverage Jun 30, 2026 8:19p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
100%
Python
100%
[✓ above threshold]
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@joshqsumner joshqsumner self-requested a review June 25, 2026 14:08
@joshqsumner

Copy link
Copy Markdown
Contributor

I changed img_list to source so that we can pass str inputs similar to the edits for pixel_scatter_plot. I was considering if there was a time that we would want to pass a list of images already in numpy form but I didn't see a situation where that would be a real workflow. I'll approve this but it might be good to bring up in dev meeting tomorrow before merging.

@joshqsumner joshqsumner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some edits and it looks good, glad to keep this in v5.

@nfahlgren nfahlgren merged commit af2d3db into v5.0 Jun 30, 2026
5 checks passed
@nfahlgren nfahlgren deleted the add-timelapse-back branch June 30, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancements to existing features ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants