Restores the time_lapse_video function#1951
Conversation
It just prints the output filename and path, which is given by the user in the first place
|
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python | Jun 30, 2026 8:19p.m. | Review ↗ | |
| Code coverage | Jun 30, 2026 8:19p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 100% [✓ above threshold] |
100% |
| Python | 100% [✓ above threshold] |
100% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
|
I changed |
joshqsumner
left a comment
There was a problem hiding this comment.
Made some edits and it looks good, glad to keep this in v5.
Describe your changes
Our plan was to deprecate the
pcv.visualize.time_lapse_videofunction because it required QT and that created conflicts with PlantCV add-on tools. Instead we were able to refactor the function to useimageioinstead of OpenCV and restore the functionality without QT. This PR also updates the function inputs to remove thedisplayparameter, which only prints out the filepath of the video but is provided by the user.We might consider changing the output value. The function returns the frame size but I think it could instead not return anything, like
pcv.print_image.Type of update
Is this a: New feature or feature enhancement
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md