Skip to content

Pixel scatter path flexibility#1933

Merged
nfahlgren merged 10 commits into
v5.0from
pixel-scatter-path-flexibility
Jul 1, 2026
Merged

Pixel scatter path flexibility#1933
nfahlgren merged 10 commits into
v5.0from
pixel-scatter-path-flexibility

Conversation

@joshqsumner

@joshqsumner joshqsumner commented May 19, 2026

Copy link
Copy Markdown
Contributor

Describe your changes
Changes paths_to_imgs to source which can take the (current) list of paths, a single str path to a directory of images, or a numpy.ndarray image, also adds n and ext arguments to control how many images are returned if using the path input.

Type of update
This is a feature enhancement.

Associated issues
Closes #1932

Additional context
None

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added this to the PlantCV v5.0 milestone May 19, 2026
@joshqsumner joshqsumner added the enhancement Enhancements to existing features label May 19, 2026
@deepsource-io

deepsource-io Bot commented May 19, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in af2d3db...5b3c45c on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Jul 1, 2026 6:26p.m. Review ↗
Code coverage Jul 1, 2026 6:26p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
100%
Python
100%
[✓ above threshold]
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@joshqsumner joshqsumner changed the base branch from main to v5.0 May 19, 2026 14:30
@joshqsumner joshqsumner mentioned this pull request May 19, 2026
8 tasks
@nfahlgren nfahlgren merged commit 56a0aca into v5.0 Jul 1, 2026
5 checks passed
@nfahlgren nfahlgren deleted the pixel-scatter-path-flexibility branch July 1, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancements to existing features ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More flexible format for arguments to pcv.visualize.pixel_scatter_plot

2 participants