Skip to content

Add empty mask handling within pcv.visualize.obj_size_ecdf#1866

Open
Nirkan wants to merge 2 commits into
danforthcenter:mainfrom
Nirkan:fix/issue-1742-obj_size_ecdf
Open

Add empty mask handling within pcv.visualize.obj_size_ecdf#1866
Nirkan wants to merge 2 commits into
danforthcenter:mainfrom
Nirkan:fix/issue-1742-obj_size_ecdf

Conversation

@Nirkan

@Nirkan Nirkan commented Jan 14, 2026

Copy link
Copy Markdown

Describe your changes
An empty mask input to pcv.visualize.obj_size_ecdf returns an error. This change returns and empty chart if the input mask is empty.

Type of update
Is this a:

  • Bug fix

Associated issues
Avoid fatal errors and instead just pass an empty mask as return #1742

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@deepsource-io

deepsource-io Bot commented Jan 14, 2026

Copy link
Copy Markdown

Here's the code health analysis summary for commits 004a6a0..e624472. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren added this to the PlantCV v4.x milestone Jun 25, 2026
@github-project-automation github-project-automation Bot moved this to Pull Requests in PlantCV4 Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pull Requests

Development

Successfully merging this pull request may close these issues.

2 participants