[DO NOT MERGE] Test CI against dandi-schema#419 consolidated models - #2866
Closed
candleindark wants to merge 3 commits into
Closed
[DO NOT MERGE] Test CI against dandi-schema#419 consolidated models#2866candleindark wants to merge 3 commits into
candleindark wants to merge 3 commits into
Conversation
Temporarily point the `dandischema` dependency at the `consolidate-models` branch of dandi/dandi-schema (PR dandi/dandi-schema#419) so this repository's CI exercises the consolidated `Dandiset`/`Asset` publication models before that PR is merged and released. This branch is throwaway and must not be merged; it exists only to run CI against the candidate schema. `backend-ci` runs the archive's own publication-validation tests against the consolidated models, and `cli-integration` additionally builds the archive image with the consolidated models while running dandi-cli with a released dandischema on the client, demonstrating that the consolidation does not force dandi-cli and dandi-archive to upgrade dandischema in lockstep. Co-Authored-By: Claude Code 2.1.212 / Claude Opus 4.8 <noreply@anthropic.com>
Merged
8 tasks
The lock recorded `60cc4de8`, which predates the `DANDI_SCHEMA_VERSION` bump to `0.8.0`. Refresh it to `99c09bf9` so that CI exercises the current state of the branch. Co-Authored-By: Claude Code 2.1.220 / Claude Opus 5 <noreply@anthropic.com>
dandi-schema#419 was rebased onto `master` after its two `api-with-schema.Dockerfile` CI commits were split out into dandi-schema#435 and merged, so its old tip (`99c09bf9`, which this lock still pointed at) no longer exists on the branch. Re-resolve the `consolidate-models` git reference to the current tip (`227cdd01`) so this PR's CI runs against what dandi-schema#419 now contains. The unrelated `secretstorage` marker simplification is incidental churn from `uv` re-canonicalizing the whole lockfile; it is semantically a no-op on every platform where `secretstorage` installs. Co-Authored-By: Claude Code 2.1.220 / Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
|
dandi/dandi-schema#419 is merged. There is no need for this PR anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a throwaway PR whose only purpose is to run this repository's CI against the consolidated
Dandiset/Assetpublication models proposed in dandi/dandi-schema#419, before that PR is merged and released. Close it once CI has reported.What it does
The single commit temporarily repoints the
dandischemadependency at theconsolidate-modelsbranch ofdandi/dandi-schema(pinned inuv.lockto the exact commit) and addstool.hatch.metadata.allow-direct-references = trueso the direct git reference is accepted.Why
dandi-schema#419's own CI already runs the archive/dandi-cli integration with the consolidated models on the client side. What it does not run is this repository's own test suite. This PR closes that gap:
backend-ciruns the archive's own publication-validation tests (the factory- and hand-built metadata validated againstPublishedDandiset/PublishedAsset) against the consolidated models.cli-integrationbuilds the archive image with the consolidated models while running dandi-cli with a releaseddandischemaon the client. A green run demonstrates that the consolidation does not force dandi-cli and dandi-archive to upgradedandischemain lockstep at the code level.Note that
DANDI_SCHEMA_VERSIONcoordination between the services at release time is a separate matter and is unaffected by what this PR verifies.Test plan
backend-cipasses against the consolidated models.cli-integrationpasses (consolidated server + released client).