Add free CreatePublisher/CreateSubscriber convenience functions#59
Open
Add free CreatePublisher/CreateSubscriber convenience functions#59
Conversation
Add inline free functions in the subspace namespace that combine client creation with publisher/subscriber creation in a single call. The returned Publisher/Subscriber already holds a shared_ptr to the ClientImpl so the client lifetime is managed automatically. Includes positive and negative tests for both functions. Made-with: Cursor
SlotSize() on a freshly created subscriber with its own client may return 0 before any messages are read. Replace the assertion with a publish-and-read round-trip that properly validates the subscriber. Made-with: Cursor
The test thread was accessing Shadow::channels_ via GetChannels() while the shadow coroutine thread concurrently mutated it in HandleEvent(). Abseil debug mode (lts_20250814) detects this as reentrant container access during emplace and aborts. Fix by adding a mutex that protects channels_, session_id_, and scb_fd_. Replace GetChannels() with a WithChannels(callback) template that holds the lock for the duration of the callback. Update all test call sites. Made-with: Cursor
The trailing return type decltype(f(channels_)) cannot resolve the private member in that context. Use plain auto deduction instead. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add inline free functions in the subspace namespace that combine client creation with publisher/subscriber creation in a single call. The returned Publisher/Subscriber already holds a shared_ptr to the ClientImpl so the client lifetime is managed automatically.
Includes positive and negative tests for both functions.
Made-with: Cursor