Skip to content

Add plan comments - #955

Open
Florian-Cullmann wants to merge 1 commit into
dalibo:masterfrom
Florian-Cullmann:fix/720-comment-field
Open

Add plan comments#955
Florian-Cullmann wants to merge 1 commit into
dalibo:masterfrom
Florian-Cullmann:fix/720-comment-field

Conversation

@Florian-Cullmann

@Florian-Cullmann Florian-Cullmann commented Aug 19, 2026

Copy link
Copy Markdown

Summary

  • add an optional plan-comment prop to the reusable Plan component
  • add a Comments field to the demo app and preserve comments through save, import, export, edit, and reopen flows
  • keep the Query tab available for comments even when no SQL query was supplied
  • document the public prop and cover the workflow with browser tests

Why

PEV2 only carried the plan source and SQL query through its component and demo data flows, so users had no dedicated place to keep context such as configuration differences or tuning notes. Comments are now stored separately from SQL and rendered safely with their original line breaks.

Impact

Existing integrations and previously saved plans remain compatible because the new component prop and stored comment value are optional.

Closes #720

@Florian-Cullmann
Florian-Cullmann marked this pull request as ready for review August 19, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comment field

1 participant