Misc refactoring parsing - #950
Open
pgiraud wants to merge 10 commits into
Open
Conversation
pgiraud
force-pushed
the
misc_refactoring_parsing
branch
4 times, most recently
from
August 17, 2026 11:43
ce0cbe0 to
e9b3196
Compare
Follow-up for 3787ad4
Instead use a revised field for that. Same for ACTUAL_STARTUP_TIME.
And set it to true when relevant.
We now search for files with `-plan` suffix and determine the corresponding `-expect` file.
InitPlan and SubPlan relationship is already set earlier. For other cases, for: - Join nodes (Nested Loop, Merge Join, Hash Join), the first child is "Outer", the others are "Inner", - Append and Bitmap, relationship is "Member", - Subquery Scan, relationship is "Subquery". A new file is added to from-text list. A SQL script is added to generate both Text and JSON format plans. However, the JSON plan needed to be adapted a bit. From the text format, it's almost impossible to determine its value since it will be only appear in verbose mode and if its true.
Right|Left Semi|Anti In the tests, I had to manually delete some keys in the expect file because it's impossible to determine them from the text format. It's the case for Inner Unique key which appears systematically in the JSON format but doesn't appear in text.
pgiraud
force-pushed
the
misc_refactoring_parsing
branch
from
August 17, 2026 13:09
e9b3196 to
4dd813c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.