Repository navigation
Conversation
fhgffy
marked this pull request as ready for review
October 4, 2026 09:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With trimming enabled, CSV fields containing quoted leading or trailing tabs survive the initial parse, but Save emits those values without quotes. Loading that saved CSV with the same parameters strips the tabs and changes the cell value. The same applies to vertical tabs and form feeds.
For example, reading
"\tvalue\t"\nwithSeparatorParams(',', true, false)produces a seven-byte value; after Save/reload it becomes five bytes on master cbd8a0a.Change
When trimming is enabled, also quote cells whose first or last byte is whitespace according to the same unsigned-char
isspaceclassification used by Trim. Existing output stays unchanged when trimming is disabled, whitespace is internal, or automatic quoting is disabled.The regression covers all three whitespace characters, leading/trailing/only/internal positions, trimming on/off, default/custom quote characters, exact saved bytes and reload integrity. Empty, UTF-8 and AutoQuote-disabled cases are included.
Validation
git diff --checkpassesUncrustify and other compiler/platform matrices were not run. Leak checking was disabled because LeakSanitizer cannot run under this environment’s ptrace configuration.