Rename uses of term 'whitelist'#7782
Merged
brian-mann merged 17 commits intov5.0-releasefrom Jun 30, 2020
Merged
Conversation
Contributor
|
Thanks for taking the time to open a PR!
|
3 tasks
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
This was referenced Jun 25, 2020
…N branch consistently
f2b0cea to
55e8297
Compare
brian-mann
approved these changes
Jun 30, 2020
5 tasks
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@Saibamen This was an unanimous decision by our team to implement in this way and goes along with many other breaking changes as part of 5.0.0 release. Please also keep in mind our code of conduct when commenting within our GitHub repo. Thank you. |
2 tasks
vfedrunov
added a commit
to vfedrunov/cypress-social-logins
that referenced
this pull request
Aug 24, 2020
renamed 'whitelist' option to 'preserve' in README according to cypress-io/cypress#7782
8 tasks
lirantal
pushed a commit
to lirantal/cypress-social-logins
that referenced
this pull request
Aug 24, 2020
renamed 'whitelist' option to 'preserve' in README according to cypress-io/cypress#7782
3 tasks
alvincrespo
added a commit
to alvincrespo/cypress-on-rails
that referenced
this pull request
Feb 6, 2021
This was referenced Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User facing changelog
Cypress.Cookies.defaults()whitelistoption has been renamed topreserveto more closely reflect its behavior.cy.server()whitelistoption has been renamed toignoreto more closely reflect its behavior.Additional details
whitelistin user-facing APIs, code, and tests.whitelisttypically means. I think this will be more explicit upfront about what the keys function is rather than a genericwhitelistorallowkey.whitelist.How has the user experience changed?
cy.server()An error will now throw when defining
whitelistfunction oncy.server().An error will now throw when defining
whitelistoption onCypress.Cookies.default().This change makes it more inclusive by replacing terms that can be perceived as offensive to more self-explanatory names (blacklist/whitelist can reinforce the association of black as bad and white as good).
Examples of projects that already made the change:
Rails
Golang
Graphite Web
HTML
PR Tasks
cypress-documentation? Rename uses of whitelist for renamed options. cypress-documentation#2928cypress-example-kitchensink? 5.0.0 Release cypress-example-kitchensink#430cypress.schema.json?