Skip to content

Change anchor links from Default-Assertions to Implicit Assertions#5637

Merged
emilyrohrbough merged 1 commit intocypress-io:mainfrom
MikeMcC399:links/default-assertions
Feb 9, 2024
Merged

Change anchor links from Default-Assertions to Implicit Assertions#5637
emilyrohrbough merged 1 commit intocypress-io:mainfrom
MikeMcC399:links/default-assertions

Conversation

@MikeMcC399
Copy link
Copy Markdown
Contributor

@MikeMcC399 MikeMcC399 commented Feb 9, 2024

https://docs.cypress.io/guides/core-concepts/introduction-to-cypress contains no bookmark Default-Assertions.

Changes

/guides/core-concepts/introduction-to-cypress#Default-Assertions is changed to
/guides/core-concepts/introduction-to-cypress#Implicit-Assertions

Verification

Execute

npm run build

and confirm that there are no reports of bad anchor links to /guides/core-concepts/introduction-to-cypress#Default-Assertions.

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 9, 2024

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c57078b

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 9, 2024

Deploy Preview for benevolent-cat-040f48 ready!

Name Link
🔨 Latest commit c57078b
🔍 Latest deploy log https://app.netlify.com/sites/benevolent-cat-040f48/deploys/65c635e3b96d100008c1c305
😎 Deploy Preview https://deploy-preview-5637--benevolent-cat-040f48.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress-app-bot
Copy link
Copy Markdown
Collaborator

@MikeMcC399 MikeMcC399 marked this pull request as ready for review February 9, 2024 14:47
Copy link
Copy Markdown
Member

@emilyrohrbough emilyrohrbough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof not sure how this passed our broken link checker...tho think it might have been broken once upon a time.

@emilyrohrbough emilyrohrbough merged commit 6f96ada into cypress-io:main Feb 9, 2024
@MikeMcC399
Copy link
Copy Markdown
Contributor Author

@emilyrohrbough

oof not sure how this passed our broken link checker...tho think it might have been broken once upon a time.

Do you mean the broken link checker which is part of Docusaurus, or are you referring to something else? If you mean Docusaurus, then broken anchor link checking is a new feature of docusaurus@3.1.0 and so this means broken anchors were previously not detected. PR #5601, merged on Jan 16, 2024, updated Docusaurus from ^2.4.1 to 3.1.1 in this repo.

@MikeMcC399 MikeMcC399 deleted the links/default-assertions branch February 9, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants