Change anchor links from Default-Assertions to Implicit Assertions#5637
Merged
emilyrohrbough merged 1 commit intocypress-io:mainfrom Feb 9, 2024
Merged
Conversation
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for benevolent-cat-040f48 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
|
emilyrohrbough
approved these changes
Feb 9, 2024
Member
emilyrohrbough
left a comment
There was a problem hiding this comment.
oof not sure how this passed our broken link checker...tho think it might have been broken once upon a time.
Contributor
Author
Do you mean the broken link checker which is part of Docusaurus, or are you referring to something else? If you mean Docusaurus, then broken anchor link checking is a new feature of docusaurus@3.1.0 and so this means broken anchors were previously not detected. PR #5601, merged on Jan 16, 2024, updated Docusaurus from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.cypress.io/guides/core-concepts/introduction-to-cypress contains no bookmark
Default-Assertions.Default-Assertionsto Implicit- Assertions in PR BREAKING: 13.0 Docs #5315Changes
/guides/core-concepts/introduction-to-cypress#Default-Assertionsis changed to/guides/core-concepts/introduction-to-cypress#Implicit-Assertions
Verification
Execute
and confirm that there are no reports of bad anchor links to
/guides/core-concepts/introduction-to-cypress#Default-Assertions.