Display drawer expand/collapse button at all times

[ChrisPaulBennett]

Closes #1137

The toolbar is now always displayed when regardless of whether the drawer is displayed or not.
Also changed the burger icon to a left arrow icon as to better reflect what it does when the drawer is expanded.

Also, altered test that checks that the toolbar is not displayed when the drawer is expanded as that is no longer desired behavior.

Check List

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
• Tests are included (or explain why tests are not needed).
• Changelog entry included if this is a change that can affect users
• Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
• If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

[Scott-Owen-James]

Saw it working and seems fine to me. Does what it says on the tin and nothing else.

[samuel-denton]

Looks good to me. I cant find any window size or arrangement of views that overlap or cause issues.

[MetRonnie]

Couple of issues with this, I'm afraid...

• The menu collapse button looks like a backwards navigation button which will confuse some users. Perhaps the "backburger" icon would be more appropriate: https://pictogrammers.com/library/mdi/icon/backburger/
• On some views we now have duplicate toolbar and banners telling you what page you are on
  • See also Combine the two toolbar components #1455

@ChrisPaulBennett Can you follow-up and tackle #1455 in the process?

[samuel-denton]

The menu collapse button looks like a backwards navigation button which will confuse some users. Perhaps the "backburger" icon would be more appropriate

I didn't think that was an issue when I reviewed but playing with the different screens again I actually did just press it intending to press the back button! Not seen the back-burger before but I agree it works here.

On some views we now have duplicate toolbar and banners telling you what page you are on

My bad, I never use the workflows table or any of those pages which have their own banner so didn't think to check them... I agree with the proposed solution to merge them, having a consistent banner on all pages is nice.

[samuel-denton]

@MetRonnie @ChrisPaulBennett should I revert the merge or is it easier to make a new PR for this?

[ChrisPaulBennett]

I didn't know the back burger was a thing. That seems perfect for this situation. Will change.
I did notice the clash with the workflow toolbar, but addressed that.
I'll create another PR to address the icon and combine the toolbars

[MetRonnie]

should I revert the merge or is it easier to make a new PR for this?

We should be able to get the follow-up PR in soon, would avoid the need for any revert as nothing is broken

[MetRonnie]

Reverted in #2543, superseded by #2542