Skip to content

Migrate to ESLint flat config & neostandard#2142

Open
MetRonnie wants to merge 1 commit into
cylc:masterfrom
MetRonnie:major-eslint
Open

Migrate to ESLint flat config & neostandard#2142
MetRonnie wants to merge 1 commit into
cylc:masterfrom
MetRonnie:major-eslint

Conversation

@MetRonnie
Copy link
Copy Markdown
Member

@MetRonnie MetRonnie commented Apr 15, 2025

Supersedes #1747

The flat config format in ESLint 9 in some ways makes more sense than the old format, but the documentation is rather lacking. Essentially, you've got an array of configuration objects, that ESLint combines.

I have moved from standard to neostandard, as standard is apparently not maintained anymore. Unfortunately, neostandard's documentation is also rather lacking. It aims to replace the need for a normal ESLint config, except that only seems to work for very simple use cases. But it can stil be combined with a normal flat ESLint config. Several of the ESLint plugins we use are bundled with neostandard, so I've removed them from our dependencies.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No new tests are needed
  • No changelog or docs needed

@MetRonnie MetRonnie added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 15, 2025
@MetRonnie MetRonnie added this to the 2.x milestone Apr 15, 2025
@MetRonnie MetRonnie self-assigned this Apr 15, 2025
Comment thread eslint.config.mjs
Comment on lines +91 to +94
plugins: {
cypress: pluginCypress,
},
extends: ['cypress/recommended'],
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found eslint/eslint#19116 more illuminating than anything in the ESLint docs!

@MetRonnie
Copy link
Copy Markdown
Member Author

MetRonnie commented Jan 30, 2026

Got a genuine lint failure which must be being newly picked up by eslint-plugin-vue since the update from 9.33.0 to 10.7.0

error Unexpected mutation of "data" prop vue/no-mutating-props

Working on it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant