Skip to content

Various small proposed improvements#909

Open
samuel-denton wants to merge 29 commits into
cylc:8.6.xfrom
samuel-denton:batch2_thoughts_on_docs
Open

Various small proposed improvements#909
samuel-denton wants to merge 29 commits into
cylc:8.6.xfrom
samuel-denton:batch2_thoughts_on_docs

Conversation

@samuel-denton
Copy link
Copy Markdown
Contributor

@samuel-denton samuel-denton commented Feb 4, 2026

https://wwwspice/~samuel.denton/cylc-doc/batch2_thoughts_on_docs/html/index.html

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.

  • Fixed a mistake on the interventions page causing tabs not to sync properly.

  • Adding tabs to the intro page to show different UI types. I find the current image a bit intimidating.

  • Added a note to Basic Cycling - Repeating Workflows to describe the reoccurrence in the example.


.. tab-item:: CLI
:sync: gui
:sync: cli
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small mistake here caused tabs to sync incorrectly.

Comment thread src/tutorial/scheduling/integer-cycling.rst Outdated
from 1.
* ``P1`` is the :term:`recurrence`; a ``P1`` :term:`graph string`
repeats at every integer :term:`cycle point`.
tells Cylc to repeat at every integer :term:`cycle point`.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change to keep consistency with other bullets.

Comment thread src/installation.rst
Comment on lines -22 to -32
.. tip::

We recommend using Mamba to install Cylc.
Mamba (or Micromamba) can be used as
`a faster, drop-in replacement for the conda command
<https://mamba.readthedocs.io/en/latest/index.html>`_.
If using Conda, make sure to use the libmamba-solver by updating to
Conda 23.10 or using the `conda-libmamba-solver plugin for conda
<https://conda.github.io/conda-libmamba-solver/getting-started/>`_.
The classic conda environment solver may be too slow for a complex package
like Cylc.
Copy link
Copy Markdown
Contributor Author

@samuel-denton samuel-denton Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#916 (comment)

This tip is no longer relevant thanks to conda adopting the Libmamba dependency resolver

mail events = failed
[[bell]]
script = printf 'bong%.02d\n' $(seq 1 $(cylc cyclepoint --print-hour))
script = printf 'bong%.02d\n' $(seq 1 $(cylc cyclepoint --print-hour)); sleep 5
Copy link
Copy Markdown
Contributor Author

@samuel-denton samuel-denton Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added sleep 5 to tutorial to allow users time to see the workflow running. A previous update to cylc sped up the running of this workflow significantly.

Comment thread src/tutorial/furthertopics/clock-triggered-tasks.rst Outdated
Comment on lines -157 to 167
* :term:`Families <family>` work best consolidating runtime configuration by
collecting tasks into broad groups, e.g. groups of tasks which run on a
particular machine or groups of tasks belonging to a particular system.
* `Jinja2`_ is good at configuring settings which apply to the entire workflow
rather than just a single task, as we can define variables then use them
throughout the workflow.
* :term:`Families <family>` work best consolidating runtime configuration by
collecting tasks into broad groups, e.g. groups of tasks which run on a
particular machine or groups of tasks belonging to a particular system.
* :term:`Parameterization <parameterization>` works best for describing tasks
which are very similar but which have subtly different configurations
(e.g. different arguments or environment variables).
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reorder to match toc tree

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GH should be showing this as outdated as the change is reverted in a following commit.

Comment thread src/tutorial/introduction.rst Outdated
Comment on lines +93 to +113
.. image:: /tutorial/img/cylc-tools.png
:alt: A screenshot of several Cylc tools.
**Placeholder Images Currently Used**

.. tab-set::

.. tab-item:: GUI

.. image:: ../../src/img/cylc-ui-dash.png
:alt: A screenshot of the Cylc GUI dashboard.
:width: 75%

.. tab-item:: Tui

.. image:: ../../src/img/tui-1.png
:alt: A screenshot of the Cylc TUI.
:width: 75%

.. tab-item:: CLI

.. image:: ../../src/img/cylc-cli.png
:alt: A screenshot of the Cylc CLI.
:width: 75%
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these tabs are a little clearer and less intimidating than the combined image used before.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cylc-tools.png can be deleted as it is no longer used.

Also, can you remove the width directive as it makes the images smaller and harder to see properly?

The text above mentions cylc scan but it is not present in the CLI screenshot. Also the CLI screenshot text is rather small even with the width directive removed.

Sorry that was a bunch of alsos 😄

Comment thread src/installation.rst
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of small wording changes to clarify what is and is not installed via pip vs conda.

@samuel-denton samuel-denton marked this pull request as ready for review March 18, 2026 13:43
@samuel-denton samuel-denton requested a review from wxtim March 18, 2026 13:43
@samuel-denton samuel-denton added this to the 8.6.x milestone Mar 18, 2026
@samuel-denton samuel-denton force-pushed the batch2_thoughts_on_docs branch from b90fb1d to 609cff9 Compare March 18, 2026 14:55
@samuel-denton samuel-denton changed the base branch from master to 8.6.x March 18, 2026 14:56
@oliver-sanders oliver-sanders requested review from ChrisPaulBennett and oliver-sanders and removed request for wxtim April 9, 2026 14:12
Copy link
Copy Markdown

@ChrisPaulBennett ChrisPaulBennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cylc cylc deleted a comment from samuel-denton Apr 27, 2026
Comment thread src/tutorial/introduction.rst Outdated
Old note removed.

Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
@samuel-denton samuel-denton marked this pull request as draft May 13, 2026 09:43
Comment on lines +313 to +314
# Generate a forecast for Exeter 300 minutes into the future.
script = post-process exeter 300
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to match the change in the Jinja2 tutorial.

@samuel-denton samuel-denton marked this pull request as ready for review May 18, 2026 16:32
@oliver-sanders oliver-sanders requested review from MetRonnie and removed request for ChrisPaulBennett May 20, 2026 13:30
@oliver-sanders
Copy link
Copy Markdown
Member

There's a bit of a problem in tutorial/runtime/configuration-consolidation/families.

It starts like so:

Families are groups of tasks which share a common configuration. In the present example the common configuration is:

script = get-observations
[[[environment]]]
    GET_NEARBY = true

However, there is no GET_NEARBY variable in the snippet on the previous change, or the previous tutorial.

The variables it then gets us to consolidate are RESOLUTION and DOMAIN:

+ [runtime]
+    [[root]]
+        [[[environment]]]
+            # The dimensions of each grid cell in degrees.
+            RESOLUTION = 0.2
+            # The area to generate forecasts for (lng1, lat1, lng2, lat2).
+            DOMAIN = -12,46,12,61  # Do not change!

@samuel-denton
Copy link
Copy Markdown
Contributor Author

However, there is no GET_NEARBY variable in the snippet on the previous change, or the previous tutorial.

I had spotted that, but I though the explainer text was somewhat separate from the practicals. The Jinja2 one for example talks about lots of things that are not touched in the practical. However I can see that it could be confusing if someone was going page by page reading the whole thing as it uses the same examples as the practical. I can look at re-wording that bit to describe one of the variables actually consolidated.

Comment on lines +220 to +221
so you should not see any difference after making these changes, other than
the MAP_FILE filename now including the resolution.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the filename change is no longer present in the PR?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep... I've changed this text so many times now I'm loosing track!

Comment thread src/tutorial/scheduling/integer-cycling.rst Outdated
Comment thread src/tutorial/introduction.rst Outdated
Comment on lines +93 to +113
.. image:: /tutorial/img/cylc-tools.png
:alt: A screenshot of several Cylc tools.
**Placeholder Images Currently Used**

.. tab-set::

.. tab-item:: GUI

.. image:: ../../src/img/cylc-ui-dash.png
:alt: A screenshot of the Cylc GUI dashboard.
:width: 75%

.. tab-item:: Tui

.. image:: ../../src/img/tui-1.png
:alt: A screenshot of the Cylc TUI.
:width: 75%

.. tab-item:: CLI

.. image:: ../../src/img/cylc-cli.png
:alt: A screenshot of the Cylc CLI.
:width: 75%
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cylc-tools.png can be deleted as it is no longer used.

Also, can you remove the width directive as it makes the images smaller and harder to see properly?

The text above mentions cylc scan but it is not present in the CLI screenshot. Also the CLI screenshot text is rather small even with the width directive removed.

Sorry that was a bunch of alsos 😄

Comment thread src/tutorial/runtime/configuration-consolidation/jinja2.rst Outdated
samuel-denton and others added 6 commits May 22, 2026 12:20
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Reworded the families page to closer match the examples being worked on.
@samuel-denton samuel-denton requested a review from MetRonnie May 22, 2026 14:42
@samuel-denton
Copy link
Copy Markdown
Contributor Author

@oliver-sanders @MetRonnie
I believe all comments have been addressed so should be ready for another look.

Comment thread src/tutorial/runtime/configuration-consolidation/jinja2.rst Outdated
Comment thread src/tutorial/runtime/configuration-consolidation/parameters.rst Outdated
Comment thread src/tutorial/runtime/configuration-consolidation/families.rst Outdated
Comment thread src/tutorial/scheduling/integer-cycling.rst Outdated
samuel-denton and others added 5 commits May 27, 2026 10:37
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
@MetRonnie MetRonnie self-requested a review May 27, 2026 10:37
Copy link
Copy Markdown
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks better now 👍 I don't have much time to go through the tutorials to check the code diffs etc are completely consistent with what you get, if someone could do so that would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants