Various small proposed improvements#909
Conversation
|
|
||
| .. tab-item:: CLI | ||
| :sync: gui | ||
| :sync: cli |
There was a problem hiding this comment.
Small mistake here caused tabs to sync incorrectly.
| from 1. | ||
| * ``P1`` is the :term:`recurrence`; a ``P1`` :term:`graph string` | ||
| repeats at every integer :term:`cycle point`. | ||
| tells Cylc to repeat at every integer :term:`cycle point`. |
There was a problem hiding this comment.
Minor change to keep consistency with other bullets.
| .. tip:: | ||
|
|
||
| We recommend using Mamba to install Cylc. | ||
| Mamba (or Micromamba) can be used as | ||
| `a faster, drop-in replacement for the conda command | ||
| <https://mamba.readthedocs.io/en/latest/index.html>`_. | ||
| If using Conda, make sure to use the libmamba-solver by updating to | ||
| Conda 23.10 or using the `conda-libmamba-solver plugin for conda | ||
| <https://conda.github.io/conda-libmamba-solver/getting-started/>`_. | ||
| The classic conda environment solver may be too slow for a complex package | ||
| like Cylc. |
There was a problem hiding this comment.
This tip is no longer relevant thanks to conda adopting the Libmamba dependency resolver
| mail events = failed | ||
| [[bell]] | ||
| script = printf 'bong%.02d\n' $(seq 1 $(cylc cyclepoint --print-hour)) | ||
| script = printf 'bong%.02d\n' $(seq 1 $(cylc cyclepoint --print-hour)); sleep 5 |
There was a problem hiding this comment.
Added sleep 5 to tutorial to allow users time to see the workflow running. A previous update to cylc sped up the running of this workflow significantly.
| * :term:`Families <family>` work best consolidating runtime configuration by | ||
| collecting tasks into broad groups, e.g. groups of tasks which run on a | ||
| particular machine or groups of tasks belonging to a particular system. | ||
| * `Jinja2`_ is good at configuring settings which apply to the entire workflow | ||
| rather than just a single task, as we can define variables then use them | ||
| throughout the workflow. | ||
| * :term:`Families <family>` work best consolidating runtime configuration by | ||
| collecting tasks into broad groups, e.g. groups of tasks which run on a | ||
| particular machine or groups of tasks belonging to a particular system. | ||
| * :term:`Parameterization <parameterization>` works best for describing tasks | ||
| which are very similar but which have subtly different configurations | ||
| (e.g. different arguments or environment variables). |
There was a problem hiding this comment.
Reorder to match toc tree
There was a problem hiding this comment.
GH should be showing this as outdated as the change is reverted in a following commit.
| .. image:: /tutorial/img/cylc-tools.png | ||
| :alt: A screenshot of several Cylc tools. | ||
| **Placeholder Images Currently Used** | ||
|
|
||
| .. tab-set:: | ||
|
|
||
| .. tab-item:: GUI | ||
|
|
||
| .. image:: ../../src/img/cylc-ui-dash.png | ||
| :alt: A screenshot of the Cylc GUI dashboard. | ||
| :width: 75% | ||
|
|
||
| .. tab-item:: Tui | ||
|
|
||
| .. image:: ../../src/img/tui-1.png | ||
| :alt: A screenshot of the Cylc TUI. | ||
| :width: 75% | ||
|
|
||
| .. tab-item:: CLI | ||
|
|
||
| .. image:: ../../src/img/cylc-cli.png | ||
| :alt: A screenshot of the Cylc CLI. | ||
| :width: 75% |
There was a problem hiding this comment.
I think these tabs are a little clearer and less intimidating than the combined image used before.
There was a problem hiding this comment.
cylc-tools.png can be deleted as it is no longer used.
Also, can you remove the width directive as it makes the images smaller and harder to see properly?
The text above mentions cylc scan but it is not present in the CLI screenshot. Also the CLI screenshot text is rather small even with the width directive removed.
Sorry that was a bunch of alsos 😄
There was a problem hiding this comment.
Lots of small wording changes to clarify what is and is not installed via pip vs conda.
…xed a mistake on the interventions page causing tabs to not sync properly.
Added sleep 5 to a tutorial and added a description of why wallclock triggers are required to run tasks in real time.
…ion so the 2 places they are listed match.
b90fb1d to
609cff9
Compare
Old note removed. Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
| # Generate a forecast for Exeter 300 minutes into the future. | ||
| script = post-process exeter 300 |
There was a problem hiding this comment.
This is to match the change in the Jinja2 tutorial.
|
There's a bit of a problem in tutorial/runtime/configuration-consolidation/families. It starts like so:
However, there is no The variables it then gets us to consolidate are
|
I had spotted that, but I though the explainer text was somewhat separate from the practicals. The Jinja2 one for example talks about lots of things that are not touched in the practical. However I can see that it could be confusing if someone was going page by page reading the whole thing as it uses the same examples as the practical. I can look at re-wording that bit to describe one of the variables actually consolidated. |
| so you should not see any difference after making these changes, other than | ||
| the MAP_FILE filename now including the resolution. |
There was a problem hiding this comment.
I think the filename change is no longer present in the PR?
There was a problem hiding this comment.
Yep... I've changed this text so many times now I'm loosing track!
| .. image:: /tutorial/img/cylc-tools.png | ||
| :alt: A screenshot of several Cylc tools. | ||
| **Placeholder Images Currently Used** | ||
|
|
||
| .. tab-set:: | ||
|
|
||
| .. tab-item:: GUI | ||
|
|
||
| .. image:: ../../src/img/cylc-ui-dash.png | ||
| :alt: A screenshot of the Cylc GUI dashboard. | ||
| :width: 75% | ||
|
|
||
| .. tab-item:: Tui | ||
|
|
||
| .. image:: ../../src/img/tui-1.png | ||
| :alt: A screenshot of the Cylc TUI. | ||
| :width: 75% | ||
|
|
||
| .. tab-item:: CLI | ||
|
|
||
| .. image:: ../../src/img/cylc-cli.png | ||
| :alt: A screenshot of the Cylc CLI. | ||
| :width: 75% |
There was a problem hiding this comment.
cylc-tools.png can be deleted as it is no longer used.
Also, can you remove the width directive as it makes the images smaller and harder to see properly?
The text above mentions cylc scan but it is not present in the CLI screenshot. Also the CLI screenshot text is rather small even with the width directive removed.
Sorry that was a bunch of alsos 😄
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Reworded the families page to closer match the examples being worked on.
|
@oliver-sanders @MetRonnie |
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
MetRonnie
left a comment
There was a problem hiding this comment.
Thanks, this looks better now 👍 I don't have much time to go through the tutorials to check the code diffs etc are completely consistent with what you get, if someone could do so that would be great
https://wwwspice/~samuel.denton/cylc-doc/batch2_thoughts_on_docs/html/index.html
Requirements check-list
I have read
CONTRIBUTING.mdand added my name as a Code Contributor.Fixed a mistake on the interventions page causing tabs not to sync properly.
Adding tabs to the intro page to show different UI types. I find the current image a bit intimidating.
Added a note to Basic Cycling - Repeating Workflows to describe the reoccurrence in the example.