Repository navigation
Conversation
dragAndDropThought waited only for the drag alert, which a held drag that moves on to a second drop target has already shown, so a snapshot could be taken before the second drop hover rendered (cybersemics#5879). Tests should not be responsible for drag-and-drop timing, so the helper now waits for the hover itself. - Each drop target element (thought rows, DropChild, DropEnd, DropUncle) renders data-drop-over, react-dnd's isOver({ shallow: true }). It names the target a drop lands on, is set in the same commit as the target's isHovering, and is true even on a target that rejects the drop. - Before its final move, the helper records when the drop target under the pointer renders that hover, and waits for the record once the drag is in progress. It records rather than polls because a Puppeteer drag dispatches dragover only when the pointer moves, so a target that moves under the stationary pointer, e.g. after hover expansion, is never hovered. It throws if the target is never hovered. - The own-position test no longer waits on .drop-hover itself. - Docs: drag-and-drop.md describes data-drop-over and corrects DropUncle's zone; testing.md lists the helper's window global. Fixes cybersemics#5879 Claude-Session: https://claude.ai/code/session_01Fd4vvqGUWV42TDr5CEEzGf Co-Authored-By: Claude claude-opus-5-5 (xhigh) <noreply@anthropic.com>
Contributor
Preview Deployment · Oct 28, 2026, 8:21 AM UTC · 3a5eb16
|
karunkop
marked this pull request as draft
October 27, 2026 16:05
karunkop
changed the title
…drop-hover # Conflicts: # docs/testing.md
karunkop
marked this pull request as ready for review
October 28, 2026 08:42
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5879
dragAndDropThoughtwaited only for the drag alert. When a held drag moves on to a second drop target (skipMouseDown), that alert is already showing. The helper then returned before the second drop hover rendered, in 11 of 40 local runs before this change and 0 of 20 after.data-drop-over, from react-dnd's shallowisOver. It is true on a target that rejects the drop too, so a drop that shows no bar still passes.dragover. A target that a hover moves under the pointer is never hovered, so polling for it would hang.state.hoveringPath, which is only written when the pointer moves and can still name the previous target..drop-hoveritself, since the helper now does.docs/drag-and-drop.mddescribes the attribute and correctsDropUncle's zone toSubthoughtsDrop.docs/testing.mdlistswindow.__dropTargetHoverWatchamong the sanctioned exceptions.Replaces #5882.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Fd4vvqGUWV42TDr5CEEzGf