OpenGL + Bug Fixes#11
Open
rhenwood39 wants to merge 24 commits into
Open
Conversation
added 24 commits
May 4, 2017 10:18
Also fixed some bugs related to functions
… map as temporary fix
Needed to create struct of undefs and then insert things individually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenGL
Regarding OpenGL, I created and finished most of opengl.ts. It hasn't really been tested yet since I don't think it is possible to "run" it yet. I think we need some C things behind the scenes for it to actually be runnable.
There is no support for splices or things like that yet. Things that are not done yet, things that will need to be changed down the road, and other miscellaneous items that could potentially be cleaned up are marked with a TODO.
Bug Fixes
Most of the bug fixes are related to functions. Instead of using the LLVM void type for void* pointers, we are now using int8's. Also, when we were building function environment structs, we were not actually putting anything inside the function pointer (i.e. we never actually made it point to the correct function). This bug has been fixed as well.
Finally, I fixed some bugs related to how we were creating structs. Specifically, there were some problems with how we were inserting non-constant values into structs.