Repository navigation
Conversation
yeongseon
approved these changes
Nov 21, 2026
yeongseon
left a comment
Contributor
There was a problem hiding this comment.
Reviewed HEAD 49e7ab2 for #587. Added offline checks compare the registry manifest's top-level version, each packages[].version, the Release Please manifest and cubrid_mcp_server.__version__; negative tests alter both manifest fields and the release version to prove the check fails. This is read-only test coverage, without modifying published metadata or release workflows. Source approved; execute the required fork workflow checks on the exact head (currently action_required) before merge.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_manifest_matches_configchecks the env defaults and the tool count in.mcpb/server.json, but not its version fields. They match__version__at 0.8.0 today and could drift in a future release. I added an offline test that compares the top levelversionand everypackages[].versioninserver.jsonwithcubrid_mcp_server.__version__and with.release-please-manifest.json.AI disclosure: I made this change with Claude Code. The code and the tests were written with it, and the commands listed below were run locally while making the change.
Changes
tests/test_docs_alignment.py: a small_manifest_version_drift()helper,test_registry_manifest_versions_match_package_versionfor the committed files, andtest_registry_manifest_version_check_reports_drift, which drifts a copy of the manifest and of the release version and checks that each mismatch is reported.Scope
Closes #587. Test only. No change to the release process, the
release-pleaseconfig or any published file.Validation
python -m pytest -q tests/test_docs_alignment.py -k registry_manifest: 2 passed..mcpb/server.jsonto 0.7.9 locally (not committed): the committed files test failed on the drifted field, and passed again after I restored the file.ruff checkandruff format --checkontests/test_docs_alignment.py: clean.make checkandmake test(coverage floor): not run, this Windows machine does not have the full toolchain. Required CI is the final evidence.tests/test_docs_alignment.pyhas one local failure,test_changelog_lint_rejects_duplicate_subsection_heading. It fails the same way on main on this machine, so it is not from this change.Safety Impact
Docs Decision
Docs: not needed - test only change.
Review and Final Disposition
server.jsonversion,packages[0].version, the release manifest and__version__) and the test failed each time, naming the drifted field.Type of Change
!to the title)Checklist
make check(lint + format-check + typecheck)make test(with the coverage floor) and all tests passmake verify(adds the livemake integrationlane; needs Docker), or explained why notdocs-not-neededlabel)Related Issues
Closes #587
Related PRs and precedence: None
Unresolved decision or dependency: None