Skip to content

test: check registry manifest versions against the package version - #591

Open
Dio77799 wants to merge 1 commit into
cubrid-lab:mainfrom
Dio77799:test/manifest-version-alignment
Open

Dio77799 wants to merge 1 commit into
cubrid-lab:mainfrom
Dio77799:test/manifest-version-alignment

Conversation

@Dio77799

Copy link
Copy Markdown

Summary

test_manifest_matches_config checks the env defaults and the tool count in .mcpb/server.json, but not its version fields. They match __version__ at 0.8.0 today and could drift in a future release. I added an offline test that compares the top level version and every packages[].version in server.json with cubrid_mcp_server.__version__ and with .release-please-manifest.json.

AI disclosure: I made this change with Claude Code. The code and the tests were written with it, and the commands listed below were run locally while making the change.

Changes

  • tests/test_docs_alignment.py: a small _manifest_version_drift() helper, test_registry_manifest_versions_match_package_version for the committed files, and test_registry_manifest_version_check_reports_drift, which drifts a copy of the manifest and of the release version and checks that each mismatch is reported.

Scope

Closes #587. Test only. No change to the release process, the release-please config or any published file.

Validation

  • Executed:
    • python -m pytest -q tests/test_docs_alignment.py -k registry_manifest: 2 passed.
    • Set .mcpb/server.json to 0.7.9 locally (not committed): the committed files test failed on the drifted field, and passed again after I restored the file.
    • ruff check and ruff format --check on tests/test_docs_alignment.py: clean.
  • Not run (and why):
    • make check and make test (coverage floor): not run, this Windows machine does not have the full toolchain. Required CI is the final evidence.
    • tests/test_docs_alignment.py has one local failure, test_changelog_lint_rejects_duplicate_subsection_heading. It fails the same way on main on this machine, so it is not from this change.
  • CUBRID version / integration evidence: not run, it does not apply to an offline test of the manifest files.

Safety Impact

  • None (docs/tooling only)
  • Read-only enforcement
  • Write mode
  • Audit logging
  • MCP protocol (stdout reserved for protocol, logs to stderr)

Docs Decision

Docs: not needed - test only change.

Review and Final Disposition

  • Required GitHub CI at final head: pending.
  • Optional review findings (Oracle, Copilot, agent-review): N/A. I did one review pass with Claude in a local session, no blocking findings. It changed each of the four values in turn (server.json version, packages[0].version, the release manifest and __version__) and the test failed each time, naming the drifted field.
  • Findings: none open.
  • Open review threads: none.
  • Maintainer decision: pending, after source, risk and required CI review.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change; add ! to the title)
  • Documentation update
  • Refactoring (no functional changes)
  • Chore (maintenance, dependencies, CI, etc.)

Checklist

  • My code follows the project's code style
  • I have run make check (lint + format-check + typecheck)
  • I have run make test (with the coverage floor) and all tests pass
  • For connection, SQL or live-behavior changes, I have run make verify (adds the live make integration lane; needs Docker), or explained why not
  • I have added tests for new functionality (if applicable)
  • I have filled in the Docs Decision section above (or applied the docs-not-needed label)
  • My changes do not introduce new warnings

Related Issues

Closes #587

Related PRs and precedence: None
Unresolved decision or dependency: None

@yeongseon yeongseon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed HEAD 49e7ab2 for #587. Added offline checks compare the registry manifest's top-level version, each packages[].version, the Release Please manifest and cubrid_mcp_server.__version__; negative tests alter both manifest fields and the release version to prove the check fails. This is read-only test coverage, without modifying published metadata or release workflows. Source approved; execute the required fork workflow checks on the exact head (currently action_required) before merge.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: keep MCP registry manifest versions aligned with the package

2 participants