Skip to content

test: cover override+public+constant in naming-convention regression #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
js360000 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test: cover override+public+constant in naming-convention regression #3027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe5f089
test: cover override+public+constant in naming-convention regression
js360000 May 17, 2026
17e4c6b
chore: retrigger CI checks
js360000 May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added ...detector_NamingConvention_0_6_11_no_warning_for_public_constants_with_override_sol__0.txt
View file
Open in desktop
Empty file.
Empty file added ..._detector_NamingConvention_0_7_6_no_warning_for_public_constants_with_override_sol__0.txt
View file
Open in desktop
Empty file.
15 changes: 15 additions & 0 deletions ...tors/test_data/naming-convention/0.6.11/no_warning_for_public_constants_with_override.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Regression coverage for https://github.com/crytic/slither/issues/930
//
// A public constant that overrides an interface getter must NOT be flagged
// by the naming-convention detector for failing UPPER_CASE_WITH_UNDERSCORES.
// The behavior is already covered by the public-constant branch in
// slither/detectors/naming_convention/naming_convention.py, but the existing
// no_warning_for_public_constants.sol fixture does not exercise the `override`
// variant. This file locks that in.
interface I {
function version() external view returns (uint256);
}

contract C is I {
uint256 public constant override version = 1;
}
15 changes: 15 additions & 0 deletions ...ctors/test_data/naming-convention/0.7.6/no_warning_for_public_constants_with_override.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Regression coverage for https://github.com/crytic/slither/issues/930
//
// A public constant that overrides an interface getter must NOT be flagged
// by the naming-convention detector for failing UPPER_CASE_WITH_UNDERSCORES.
// The behavior is already covered by the public-constant branch in
// slither/detectors/naming_convention/naming_convention.py, but the existing
// no_warning_for_public_constants.sol fixture does not exercise the `override`
// variant. This file locks that in.
interface I {
function version() external view returns (uint256);
}

contract C is I {
uint256 public constant override version = 1;
}
10 changes: 10 additions & 0 deletions tests/e2e/detectors/test_detectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,16 @@ def id_test(test_item: Test):
"no_warning_for_public_constants.sol",
"0.7.6",
),
Test(
all_detectors.NamingConvention,
"no_warning_for_public_constants_with_override.sol",
"0.6.11",
),
Test(
all_detectors.NamingConvention,
"no_warning_for_public_constants_with_override.sol",
"0.7.6",
),
Test(
all_detectors.ControlledDelegateCall,
"controlled_delegatecall.sol",
Expand Down