Skip to content

Remove obsolete solc AST CLI flag #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nhatdo9825-cmyk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove obsolete solc AST CLI flag #3024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions scripts/ci_test_cli.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ set -euo pipefail

solc-select use 0.7.0

if ! slither "tests/e2e/config/test_json_config/test.sol" --solc-ast --no-fail-pedantic; then
echo "--solc-ast failed"
exit 1
fi

if ! slither "tests/e2e/config/test_json_config/test.sol" --solc-disable-warnings --no-fail-pedantic; then
echo "--solc-disable-warnings failed"
exit 1
Expand Down
9 changes: 1 addition & 8 deletions slither/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,13 +622,6 @@ def parse_args(
default="#",
)

group_misc.add_argument(
"--solc-ast",
help="Provide the contract as a json AST",
action="store_true",
default=False,
)

group_misc.add_argument(
"--generate-patches",
help="Generate patches (json output only)",
Expand Down Expand Up @@ -906,7 +899,7 @@ def main_impl(
filename = args.filename

# Determine if we are handling ast from solc
if args.solc_ast or (filename.endswith(".json") and not is_supported(filename)):
if filename.endswith(".json") and not is_supported(filename):
globbed_filenames = glob.glob(filename, recursive=True)
filenames = glob.glob(os.path.join(filename, "*.json"))
if not filenames:
Expand Down