improve docker / appsec sections#2
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Docker installation guidance and AppSec deployment notes to better reflect real-world Docker/compose behavior, especially around log acquisition, hub env var behavior, and bouncer/AppSec connectivity.
Changes:
- Expanded Docker install “gotchas” with a Docker datasource example (
source: docker) and clarified log/acquisition diagnostics. - Reworked hub env var behavior explanation (install-on-boot vs uninstall) and clarified
GIDimplications. - Clarified AppSec Docker/compose requirements and added a cross-reference for containerized lua bouncer DNS resolver behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
crowdsec/references/install/docker.md |
Refines Docker install troubleshooting: acquisition paths, Docker datasource example, hub env var behavior, GID clarification, and bouncer endpoint/resolver notes. |
crowdsec/references/appsec/deploy.md |
Updates Docker/compose AppSec notes (listen address + internal service URL) and links to Docker bouncer bootstrap/resolver guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.