docs(epoch): fix defer_destroy Send rationale example#1256
Open
leno23 wants to merge 1 commit into
Open
Conversation
The previous example used `Shared<i32>`, which is Send because `i32` is Send, so it did not illustrate why `defer_destroy` omits a `T: Send` bound. Use a nested `Shared<Shared<i32>>` example instead and note that the method delegates to `defer_unchecked`. Fixes crossbeam-rs#1253 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1253.
The
defer_destroydocumentation reused an example fromdefer_uncheckedthat usedShared<i32>. Becausei32isSend, that example did not demonstrate why the API omits aT: Sendbound.This updates the example to use nested
Shared<Shared<i32>>and clarifies thatdefer_destroydelegates todefer_unchecked.Test plan