DO NOT MERGE: Support non-latin formats#70
Open
er1c wants to merge 2 commits intocquiroz:mainfrom
Open
Conversation
Collaborator
Author
|
@er1c this is reproducible with |
Collaborator
Author
|
@er1c you can use |
Owner
|
@er1c I tested this locally and I reproduce that it works on JVM but not on JS, any plans about getting this to work? |
Collaborator
Author
|
@cquiroz there is a reason it says do not merge :) we need to fix the getZeroDigit to pull from the CLDR, then I think this should work |
Owner
|
Ok, no pressure, just checking in 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason this breaks on the JVM, even though its not reproducible on the console: