tests: add solver delegate coverage by igorroncevic · Pull Request #3 · cowprotocol/solver-7702-delegate

igorroncevic · 2026-05-14T13:18:42Z

Summary

This PR adds test coverage for Solver7702Delegate.

What changed

Added unit tests for constructor setup, approved callers, fallback forwarding, ETH forwarding, return data, revert bubbling, short calldata, empty calldata, and unauthorized callers.
Added integration tests for GPv2-style settlement calls, including direct versus delegated gas snapshots.
Added fork tests for real GPv2 settlement calls across supported networks and historical mainnet orders.
Added mocks and helpers for settlement-style calldata, target calls, raw return data, and raw revert data.
Added fork RPC examples, OpenZeppelin test dependency wiring, and gas snapshots.
Updated CI so gas snapshots are checked during tests.
Cleaned up review feedback by fuzzing empty target payloads, removing duplicate fuzz coverage, and making the GPv2 mock value behavior match its comments.

Test plan

Run:

just all

gemini-code-assist

Code Review

This pull request introduces a comprehensive test suite for the Solver7702Delegate contract, including unit, integration, and fork tests, along with necessary mocks and gas snapshots. It also adds documentation to the fallback function regarding the expected calldata format. Feedback focuses on correcting the invalid Solidity pragma version 0.8.34 to a stable release and improving fuzz test coverage by allowing empty payloads instead of substituting them with 0x00.

Copilot

Pull request overview

Adds a comprehensive Foundry test suite around Solver7702Delegate’s EIP-7702 delegated fallback forwarding behavior, including unit, integration (mock GPv2), and fork-based regression tests.

Changes:

Added unit/integration/fork tests plus supporting mocks and utilities for constructing settlement-like calldata and revert/return-data scenarios.
Added gas snapshot JSONs for the new test suites.
Updated tooling/config (test solhint overrides, coverage exclusions to ignore lib/, Foundry remappings, .env.example, and OpenZeppelin submodule pin).

Reviewed changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/utils/SettlementUtils.sol	Utility library to build mock/real GPv2 settlement calldata for integration/fork tests.
test/utils/MathUtils.sol	Small test-only math helper library.
test/Solver7702Delegate.t.sol	Unit tests covering constructor behavior and fallback forwarding/revert bubbling.
test/Solver7702Delegate.integration.t.sol	Integration tests using mocked GPv2 settlement/authenticator.
test/Solver7702Delegate.fork.t.sol	Fork tests against real GPv2 settlement across networks plus historical calldata replay.
test/mocks/targets/RevertingTarget.sol	Target contract producing standard Solidity revert shapes (custom error/string/panic/empty).
test/mocks/targets/RawRevertTarget.sol	Target contract that reverts with arbitrary raw bytes.
test/mocks/targets/PayableFallbackTarget.sol	Payable fallback/receive target used to assert exact forwarding semantics.
test/mocks/targets/NonpayableTarget.sol	Nonpayable target used to assert value-forwarding failure behavior.
test/mocks/MockSettlement.sol	Simple payable settlement-like target for delegate integration tests.
test/mocks/MockGPv2Settlement.sol	Minimal GPv2 settlement mock that checks solver allowlist and executes interactions.
test/mocks/MockGPv2Authenticator.sol	Minimal solver allowlist mock used by integration tests.
test/dependencies/settlement/IGPv2Settlement.sol	Test-local GPv2 settlement interface/types used by mocks and calldata builders.
test/dependencies/settlement/IGPv2Authenticator.sol	Test-local GPv2 authenticator interface used by mocks.
test/BaseTest.t.sol	Shared test harness: approved callers, packed calldata helper, delegation attachment helper.
test/.solhint.json	Test-folder solhint overrides to accommodate patterns used in the new tests.
src/Solver7702Delegate.sol	Added calldata-format documentation to the fallback function.
snapshots/Solver7702DelegateTest.json	Gas snapshot baselines for unit tests.
snapshots/Solver7702DelegateIntegrationTest.json	Gas snapshot baselines for integration tests.
snapshots/Solver7702DelegateForkTest.json	Gas snapshot baselines for fork tests.
Justfile	Adjusted `test`/coverage commands (including excluding `lib/` from coverage).
foundry.toml	Added OpenZeppelin remapping and formatting adjustment.
foundry.lock	Added OpenZeppelin submodule pin.
.gitmodules	Added OpenZeppelin contracts submodule.
.env.example	Added RPC URL environment variables for fork testing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

igorroncevic · 2026-05-15T14:03:21Z

-test:
-    {{FORGE}} test -vvv --show-progress --gas-snapshot-check true
+test *args:
+    {{FORGE}} test -vvv --show-progress {{args}}

 # Print coverage summary
 coverage-summary:
-    {{FORGE}} coverage --no-match-coverage "^(test|script)/" --report summary
+    {{FORGE}} coverage --no-match-coverage "^(test|script|lib)/" --report summary

 # Generate lcov coverage report
 coverage-lcov:
-    {{FORGE}} coverage --no-match-coverage "^(test|script)/" --report lcov
+    {{FORGE}} coverage --no-match-coverage "^(test|script|lib)/" --report lcov


I've added these modifications to the contracts-template repo as well

Basically:

don't check snapshots locally, only in the CI, otherwise you can't generate them locally with just test

lib was getting caught in coverage so I removed it

igorroncevic · 2026-05-15T14:03:51Z

Added for mocks and possibly other utilities for testing. Isn't used in src/

igorroncevic · 2026-05-15T14:04:27Z

+    env:
+      ETH_MAINNET_RPC_URL: ${{ secrets.ETH_MAINNET_RPC_URL }}
+      GNOSIS_RPC_URL: ${{ secrets.GNOSIS_RPC_URL }}
+      ARBITRUM_ONE_RPC_URL: ${{ secrets.ARBITRUM_ONE_RPC_URL }}
+      BASE_RPC_URL: ${{ secrets.BASE_RPC_URL }}
+      OPTIMISM_RPC_URL: ${{ secrets.OPTIMISM_RPC_URL }}
+      POLYGON_RPC_URL: ${{ secrets.POLYGON_RPC_URL }}
+      BNB_MAINNET_RPC_URL: ${{ secrets.BNB_MAINNET_RPC_URL }}
+      PLASMA_RPC_URL: ${{ secrets.PLASMA_RPC_URL }}
+      AVALANCHE_RPC_URL: ${{ secrets.AVALANCHE_RPC_URL }}
+      INK_RPC_URL: ${{ secrets.INK_RPC_URL }}
+      LINEA_RPC_URL: ${{ secrets.LINEA_RPC_URL }}


Supported sample tests for all networks just to be sure ERC-7702 is present on all of them and generally as a sanity check.

igorroncevic · 2026-05-15T14:04:38Z

      - uses: ./.github/actions/setup
      - name: Test
-        run: just test
+        run: just test --gas-snapshot-check true


See comment below on Justfile

tests: wip

cf9c6c6

gemini-code-assist Bot reviewed May 14, 2026

View reviewed changes

Comment thread test/BaseTest.t.sol

Comment thread test/Solver7702Delegate.t.sol Outdated

igorroncevic added 5 commits May 14, 2026 17:59

better tests

0f099e3

unit tests

3f02a52

refactor

4d3ca32

integration tests

c0e4aa2

fork tests

7e00d57

igorroncevic marked this pull request as ready for review May 15, 2026 11:53

igorroncevic requested a review from a team as a code owner May 15, 2026 11:53

igorroncevic requested a review from Copilot May 15, 2026 11:53

Copilot started reviewing on behalf of igorroncevic May 15, 2026 11:54 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

Comment thread test/mocks/MockGPv2Settlement.sol

Comment thread test/Solver7702Delegate.t.sol Outdated

Comment thread Justfile Outdated

igorroncevic self-assigned this May 15, 2026

igorroncevic added 4 commits May 15, 2026 14:01

check snapshots in CI

6dd4735

add other networks

6014b9e

more precise snapshot

d5f4220

test: address PR review comments

7377c12

igorroncevic mentioned this pull request May 15, 2026

feat: setup #2

Open

add rpc urls to env

d0db7b4

igorroncevic commented May 15, 2026

View reviewed changes

fix tests

626efad

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: add solver delegate coverage#3

tests: add solver delegate coverage#3
igorroncevic wants to merge 12 commits into
feat/setupfrom
test/add-tests

igorroncevic commented May 14, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

igorroncevic May 15, 2026

Uh oh!

igorroncevic May 15, 2026

Uh oh!

igorroncevic May 15, 2026

Uh oh!

igorroncevic May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

igorroncevic commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What changed

Test plan

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

igorroncevic May 15, 2026

Choose a reason for hiding this comment

Uh oh!

igorroncevic May 15, 2026

Choose a reason for hiding this comment

Uh oh!

igorroncevic May 15, 2026

Choose a reason for hiding this comment

Uh oh!

igorroncevic May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

igorroncevic commented May 14, 2026 •

edited

Loading