Skip to content

wrap RawAuctionData in Arc for efficient sharing #4392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashleychandy wants to merge 5 commits into
base: main
Choose a base branch
from
Open

wrap RawAuctionData in Arc for efficient sharing #4392

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9bf8895
wrap RawAuctionData in Arc for efficient sharing
ashleychandy May 10, 2026
91d15dd
pass RawAuctionData by reference in persistence DTOs
ashleychandy May 10, 2026
880136a
derive Copy for small enums and optimize DTO conversions
ashleychandy May 10, 2026
5bb14c1
Merge branch 'cowprotocol:main' into perf/arc-raw-auction-data
ashleychandy May 16, 2026
c52b252
delay RawAuctionData clone until domain::Auction construction
ashleychandy May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions crates/autopilot/src/infra/persistence/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,27 +156,31 @@ impl Persistence {
pub fn replace_current_auction_in_db(
&self,
new_auction_id: domain::auction::Id,
new_auction_data: &domain::RawAuctionData,
new_auction_data: &Arc<domain::RawAuctionData>,
) {
self.upload_queue
.send(AuctionUpload {
auction_id: new_auction_id,
auction_data: dto::auction::from_domain(new_auction_data.clone()),
auction_data: dto::auction::from_domain(new_auction_data.as_ref().clone()),
Comment thread
ashleychandy marked this conversation as resolved.
Outdated
})
.expect("upload queue should be alive at all times");
}

/// Spawns a background task that uploads the auction to S3.
pub fn upload_auction_to_s3(&self, id: domain::auction::Id, auction: &domain::RawAuctionData) {
pub fn upload_auction_to_s3(
&self,
id: domain::auction::Id,
auction: &Arc<domain::RawAuctionData>,
) {
if auction.orders.is_empty() {
return;
}
let Some(s3) = self.s3.clone() else {
return;
};
let auction = auction.clone();
let auction = Arc::clone(auction);
tokio::task::spawn(async move {
let auction_dto = dto::auction::from_domain(auction);
let auction_dto = dto::auction::from_domain(auction.as_ref().clone());
match s3.upload(id.to_string(), auction_dto).await {
Ok(key) => tracing::info!(?key, "uploaded auction to s3"),
Err(err) => tracing::warn!(?err, "failed to upload auction to s3"),
Expand Down
6 changes: 3 additions & 3 deletions crates/autopilot/src/run_loop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,9 +302,9 @@ impl RunLoop {
Some(domain::Auction {
id,
block: auction.block,
orders: auction.orders,
prices: auction.prices,
surplus_capturing_jit_order_owners: auction.surplus_capturing_jit_order_owners,
orders: auction.orders.clone(),
prices: auction.prices.clone(),
surplus_capturing_jit_order_owners: auction.surplus_capturing_jit_order_owners.clone(),
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

These lines perform deep clones of the orders, prices, and surplus_capturing_jit_order_owners collections on every auction cycle. While this is necessary because domain::Auction expects owned data, it significantly limits the performance gains of wrapping RawAuctionData in an Arc. To fully achieve the goal of efficient sharing, consider refactoring the domain::Auction struct to use Arc for its collection fields, allowing these to be cheap pointer increments instead of deep copies.

})
}

Expand Down
8 changes: 4 additions & 4 deletions crates/autopilot/src/solvable_orders.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ pub struct SolvableOrdersCache {
type Balances = HashMap<Query, U256>;

struct Inner {
auction: domain::RawAuctionData,
auction: Arc<domain::RawAuctionData>,
solvable_orders: boundary::SolvableOrders,
}

Expand Down Expand Up @@ -186,12 +186,12 @@ impl SolvableOrdersCache {
})
}

pub async fn current_auction(&self) -> Option<domain::RawAuctionData> {
pub async fn current_auction(&self) -> Option<Arc<domain::RawAuctionData>> {
self.cache
.lock()
.await
.as_ref()
.map(|inner| inner.auction.clone())
.map(|inner| Arc::clone(&inner.auction))
}

/// Manually update solvable orders. Usually called by the background
Expand Down Expand Up @@ -358,7 +358,7 @@ impl SolvableOrdersCache {
};

*self.cache.lock().await = Some(Inner {
auction,
auction: Arc::new(auction),
solvable_orders: db_solvable_orders,
});

Expand Down
Loading