driver: parallelize unsupported order detection

crates/driver/src/domain/competition/mod.rs

@@ -33,7 +33,7 @@ use {
         time::Instant,
     },
     tokio::{sync::mpsc, task},
-    tracing::{Instrument, instrument},
+    tracing::Instrument,
 };
 
 pub mod auction;
@@ -339,11 +339,11 @@ impl Competition {
             Self::sort_orders(auction, solver_address, order_sorting_strategies)
         });
 
-        // We can sort the orders and fetch auction data in parallel
+        // We can sort the orders and fetch auction data in parallel.
         let (auction, balances, app_data) =
             tokio::join!(sort_orders_future, tasks.balances, tasks.app_data);
 
-        let auction = Self::run_blocking_with_timer("update_orders", move || {
+        let mut auction = Self::run_blocking_with_timer("update_orders", move || {
             // Same as before with sort_orders, we use spawn_blocking() because a lot of CPU
             // bound computations are happening and we want to avoid blocking
             // the runtime.
@@ -352,14 +352,21 @@ impl Competition {
         .await;
 
         // We can run bad token filtering and liquidity fetching in parallel
-        let (liquidity, auction) = tokio::join!(
+        let (_, liquidity) = tokio::join!(
+            async {
+                self.risk_detector
+                    .filter_unsupported_orders_in_auction(
+                        &mut auction,
+                        self.solver.config().flashloans_enabled,
+                    )
+                    .await
+            },
             async {
                 match self.solver.liquidity() {
                     solver::Liquidity::Fetch => tasks.liquidity.await,
                     solver::Liquidity::Skip => Arc::new(Vec::new()),
                 }
-            },
-            self.without_unsupported_orders(auction)
+            }
         );
 
         let elapsed = start.elapsed();
@@ -951,16 +958,6 @@ impl Competition {
         }
         Ok(())
     }
-
-    #[instrument(skip_all)]
-    async fn without_unsupported_orders(&self, mut auction: Auction) -> Auction {
-        if !self.solver.config().flashloans_enabled {
-            auction.orders.retain(|o| o.app_data.flashloan().is_none());
-        }
-        self.risk_detector
-            .filter_unsupported_orders_in_auction(auction)
-            .await
-    }
 }
 
 const MAX_SOLUTIONS_TO_MERGE: usize = 10;