Skip to content

feature: lern-fair adoptions to support our needs #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dhenkel92 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feature: lern-fair adoptions to support our needs #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
bundle
cjs
esm
node_modules
coverage
tunnel.log
Expand Down
18 changes: 6 additions & 12 deletions packages/core/src/browser/cookie.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,23 @@
import { display } from '../tools/display'
import { ONE_MINUTE, ONE_SECOND } from '../tools/utils/timeUtils'
import { findCommaSeparatedValue, generateUUID } from '../tools/utils/stringUtils'
import { generateUUID } from '../tools/utils/stringUtils'

export interface CookieOptions {
secure?: boolean
crossSite?: boolean
domain?: string
}

export function setCookie(name: string, value: string, expireDelay: number, options?: CookieOptions) {
const date = new Date()
date.setTime(date.getTime() + expireDelay)
const expires = `expires=${date.toUTCString()}`
const sameSite = options && options.crossSite ? 'none' : 'strict'
const domain = options && options.domain ? `;domain=${options.domain}` : ''
const secure = options && options.secure ? ';secure' : ''
document.cookie = `${name}=${value};${expires};path=/;samesite=${sameSite}${domain}${secure}`
export function setCookie(name: string, value: string, _expireDelay: number, _options?: CookieOptions) {
sessionStorage.setItem(name, value)
}

export function getCookie(name: string) {
return findCommaSeparatedValue(document.cookie, name)
return sessionStorage.getItem(name)
}

export function deleteCookie(name: string, options?: CookieOptions) {
setCookie(name, '', 0, options)
export function deleteCookie(name: string, _options?: CookieOptions) {
sessionStorage.removeItem(name)
}

export function areCookiesAuthorized(options: CookieOptions): boolean {
Expand Down
2 changes: 1 addition & 1 deletion packages/rum/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"replace-build-env": "node ../../scripts/build/replace-build-env.js"
},
"dependencies": {
"@datadog/browser-core": "4.49.0",
"@datadog/browser-core": "https://gitpkg.now.sh/corona-school/browser-sdk/packages/core?v4.49-lern-fair-packages",
"@datadog/browser-rum-core": "4.49.0"
},
"peerDependencies": {
Expand Down