Apply CFLAGS to assembly file compilation - #75
Open
michich wants to merge 1 commit into
Open
Conversation
The .S → .o build rule used only $(ASFLAGS), which amounted to just
"-g3 -fpic". This meant that when building as a Fedora RPM, the
hardening flags from %{set_build_flags} (set via CFLAGS) were not
applied to assembly files — no annobin, no stack protector specs, etc.
Add $(CFLAGS) $(BASECFLAGS) $(INCLUDES) to match the .c compilation
rule and the .S dependency-generation rule.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Contributor
|
Thanks; we'll try this out and, assuming no issues, approve it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .S → .o build rule used only
$(ASFLAGS), which amounted to just "-g3 -fpic". This meant that when building as a Fedora RPM, the hardening flags from%{set_build_flags}(set via CFLAGS) were not applied to assembly files — no annobin, no stack protector specs, etc.Add
$(CFLAGS) $(BASECFLAGS) $(INCLUDES)to match the .c compilation rule and the .S dependency-generation rule.