Merge updates into master#6
Open
mayorbyrne wants to merge 3 commits intocoreybutler:masterfrom
Open
Conversation
Owner
|
I'm finally getting around to this. Is there really a trailing I think something should be done about this, but instead of eliminating the dash, perhaps it would be better to have a default message like In other words, this line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was just playing around and re-familiarizing myself with the library, doing some unit testing, and realized if you pass nothing into
.pass()or.fail()there was a trailing-logged. This PR attempts to fix this. No worries if this is garbage and gets rejected.