test(examples): Add credential-free documentation example harness - #382
Draft
thedriftofwords wants to merge 6 commits into
Draft
test(examples): Add credential-free documentation example harness#382thedriftofwords wants to merge 6 commits into
thedriftofwords wants to merge 6 commits into
Conversation
Made-with: Cursor
Declare the CoreWeave provider source so copied examples resolve the correct provider and support Terraform initialization. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace org-wide CW wildcard principals with one console user and one SAML group ARN, keeping cw:PrincipalOrgID as an extra safety measure. Co-authored-by: Cursor <cursoragent@cursor.com>
Validate registered Terraform examples with fmt, init, and validate in isolated temporary directories. Expose the command as make test-examples and run it in CI. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terraform fmt -check,terraform init -backend=false, andterraform validate.make -f GNUmakefile test-examplesand runs it in CI.examples/README.md.Dependency
Draft until coreweave/terraform-provider-coreweave#304 merges.
This branch is rebased on PR #304 so the harness validates the updated bucket policy examples, including
required_providersand named principal ARNs. After #304 lands, rebase this branch ontomainand mark ready for review.Related: DOCS-3002
Test plan
make -f GNUmakefile test-examplesgo test ./coreweave/object_storage.terraform/or lockfiles are left underexamples/test-examplesjob passes after rebase ontomainpost-docs(object-storage): Scope bucket policy examples by org condition #304Design notes
validate(noplanorapply).tools/test-examples.sh.Made with Cursor