deps: update Go to 1.26.5 - #377
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Go toolchain/linting configuration to align local tooling (mise) and module declarations with Go 1.26.5, and adjusts golangci-lint configuration to keep the toolchain bump independently buildable.
Changes:
- Bump
goversion in bothgo.modfiles to1.26.5. - Update mise tool pins to Go
1.26.5andgolangci-lint2.9.0. - Temporarily disable the
prealloclinter in.golangci.yaml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tools/go.mod |
Updates tools module Go version to 1.26.5. |
go.mod |
Updates provider module Go version to 1.26.5. |
.golangci.yaml |
Temporarily disables prealloc in the enabled linters list. |
.config/mise.toml |
Pins mise-managed Go and golangci-lint versions to the new toolchain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - makezero | ||
| - nakedret | ||
| - prealloc | ||
| # - prealloc |
AndresRCB
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the repository toolchain to Go 1.26.5 and golangci-lint 2.9.0. This is layer 1 of stack #379; #378 builds on it to re-enable
preallocafter fixing the newly enforced findings.Changes
preallocfor this independently buildable layer.Validation
make buildmake lint(0 issues)go test ./coreweave/cks ./coreweave/inference ./coreweave/networking ./coreweave/object_storagemake generate(no generated diff)git diff --checkgovulncheck ./...using v1.1.4 rebuilt with Go 1.26.5Caveats
The vulnerability scan reports five existing reachable findings in gRPC, x/text, AWS SDK v2, and x/net. Dependency remediation is intentionally outside this toolchain-only layer.