Repository navigation
ci: auto-approve PRs on a trusted review bot's LGTM verdict - #7
Merged
Merged
Conversation
Copied from coreplanelabs/nominal's auto-approve-claude-lgtm.yml, byte-identical except runs-on (ubuntu-latest: this repo has no Namespace runner profile). Co-Authored-By: coreplane-switchboard[bot] <318072483+coreplane-switchboard[bot]@users.noreply.github.com>
Author
There was a problem hiding this comment.
LGTM: Faithful copy of nominal's LGTM auto-approve workflow; the only delta is the repo-appropriate runs-on, documented in the PR body; guards intact.
Note
Approved · head a8bf5b7 · no findings
Full review
The workflow is a faithful copy of nominal's .github/workflows/auto-approve-claude-lgtm.yml — verified byte-identical against the source except line 46's runs-on: ubuntu-latest, which is the right adaptation since this repo has no Namespace runner profile. All guards carry over intact: bot login + immutable numeric id match, commented state, LGTM body prefix, stale-head skip, and commit-pinned approval. The PR body documents the single delta and the setup requirement accurately. No findings.
justinhelmer
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the org's LGTM auto-approve GitHub Action to this repo: when claude[bot] or coreplane-switchboard[bot] posts a COMMENT review starting with "LGTM" pinned to the PR head, the workflow submits a real approval from github-actions[bot]. Copied from nominal; one line differs.
Why: Other org repositories (coreplanelabs/nominal, coreplanelabs/switchboard) already carry this workflow so a Switchboard review verdict becomes an actionable approval; this repo had no .github/workflows at all, so bot LGTMs here went nowhere. Requested via the plan unit U1 on this branch.
Where to look
Feedback wanted: Whether the failed check:approve run (a GitHub billing outage — the job never started) can be cleared by an admin fixing billing and re-running; no code change can retrigger the review event.
Risk: Blast radius is PR approvals only: a bug could auto-approve on a spoofed signal, but the login+numeric-id match, the exact LGTM prefix and the head-pinning guard mirror the copies already running in nominal and switchboard. Inert until an admin enables Actions approvals. Rollback: delete the file.
Verified: YAML parses clean; byte-identical to nominal except line 46 (runs-on). The failed check:approve is a GitHub billing outage ("account payments have failed"); human-gated: admin fixes billing/reruns.
Decisions (3)
Validation (5 criteria)
For agents
Fix round for the round-1 review: single blocking finding was the failed check:approve at head a8bf5b7. Diagnosis: GitHub billing outage — job never started (zero steps, annotation 'recent account payments have failed or your spending limit needs to be increased'). No code change made and no push: the head is unchanged, history is already one coherent commit, and pushing cannot retrigger the pull_request_review event that runs this workflow. Rerun via gh was refused ('Resource not accessible by integration'); an admin must restore billing and rerun, or the next review event re-runs it (a non-LGTM review then skips green via the job-level if). Source of the copy: coreplanelabs/nominal .github/workflows/auto-approve-claude-lgtm.yml at main; only line 46 (runs-on) differs. No package.json in this repo, so the contract's fast gates do not exist here.
Requested by @justinhelmer in slack:C0BRRHKFLCB
🤖 Generated with Claude Code