Repository navigation
fix: rewrite user-facing scan copy as value language (W6) - #44
Merged
Merged
Conversation
Replace every user-visible "scan" string with copy that says what the user gets: finding issues and surfacing risks. Command name, flags, identifiers, API routes, and generated code are untouched. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PMSrf1N3WfRXaXxcuuzoER
justinhelmer
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Justin Helmer · Slack thread
Before: the CLI talked about scanning ("Scanning 3 cloud accounts…", "Finding scan targets…", "The staging scan didn't finish"). After: every user-visible string says what the user gets: issues found and risks surfaced.
"Scan" frames the work as us extracting value from the user instead of delivering value to them, so it disappears from everything a user can read (W6 of the onboarding rework, coreplanelabs/nominal#1227).
How: each string was rewritten for its context rather than find/replaced. The
scancommand name, file names, function and type identifiers, thescan_reports.*API routes, generated client code, and console/scansURLs are all untouched; this PR is copy only. Tests asserting the old copy were updated, and root help stays within the 35-line cap (one description line changed, none added).Notable rewrites
Scan connected cloud accounts and integrations for key risks(help description,--helpand root help)Find key risks in your connected cloud accounts and integrationsScanning 3 cloud accounts and 2 integrations… (1/5 complete)(progress spinner)Finding issues in 3 cloud accounts and 2 integrations… (1/5 complete)Finding scan targets…(spinner)Checking what's connected…Nothing to scan yet: no cloud accounts or integrations are connected.Nothing to check yet: no cloud accounts or integrations are connected.The <label> scan didn't finish (…).The <label> check didn't finish (…).2 scans are still running; view progress in the console.Still looking for issues in 2 places; view progress in the console.Workspace to scan(prompt)Workspace to checkRemaining "scan" audit
grep -rni scanover the repo (excluding node_modules, dist, .git, package-lock.json) leaves 181 hits, all out-of-scope identifiers, grouped by category:Command name (kept by design):
src/commands/scan.ts— command/file name,name: 'scan', examplespolylane scan …(3 hits among its 55)src/registry.ts(1) —scanresource key/name inRESOURCE_ORDERsrc/main.ts(part of 3) —'scan'in the pre-auth command routing listsrc/commands/index.ts(2) —scanCommandimport/registrationtest/resolve.test.ts(1),test/registry.test.ts(5) — command name in routing/typo-suggestion testsCode identifiers (types, functions, fixtures):
src/commands/scan.ts(bulk of 55) —ScanTarget,ScanRunResult,RunScanOps,runScans,scanProgressLabel,scansIndexUrl,SCAN_TIMEOUT_MS,seedInvestigationsparams, plus/scansconsole-URL parsingtest/scan.test.ts(59) — imports of those identifiers,scan_report_*fixture ids,/scansURLs, test descriptions (developer-facing, not user output)API routes / operationIds (machine contract):
src/client/scan-reports.ts(33) —/v1/scan_reportsroutes,ScanReport*request/response types, code commentssrc/generated/{types,client,commands}.ts(7) — auto-generated from the OpenAPI spec (scan_reports.*operationIds), do-not-editsrc/commands/scan.ts—operationId: 'scan_reports.generate'Different meaning of "scan" (argument parsing, not the product feature):
src/args.ts(1),src/main.ts(2 of 3),test/args.test.ts(8) —scanCommandPath, the argv tokenizerFalse positives:
src/utils/prompt.ts(6) —p.isCancelmatches "sCan" case-insensitivelyVerification
npm run typecheck— passnpm run lint— passnpm run test— 258/258 passGenerated by Claude Code