image-builder/disks.yaml: set XFS agcount #4254
Draft
jbtrystram wants to merge 2 commits into
Draft
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Add the partition names to the `disk.yaml` image-builder configuration file. The partitions were correctly labelled at the filesystem level but were missing names from the GPT parition table. This was causing some issues with reprovisionning. Let's make sure the resulting partition table is identical to what we have when building disk-images with COSA. See how partitions names are set in COSA at the GPT table : https://github.com/coreos/coreos-assembler/blob/a2b4dd6c901c074fb36e6d61df114b4386c4bc74/src/osbuild-manifests/coreos.osbuild.x86_64.mpp.yaml#L65
jbtrystram
force-pushed
the
disk-image-xfs-agcount
branch
from
b4bf575 to
8256263
Compare
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #4253
Requires osbuild/image-builder#2496