feat: multi-tenant with embrella integration - #10
Open
david-dong-biohub wants to merge 9 commits into
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
Collaborator
Author
|
seems to fail the backend check since we added more env vars. Will fix |
david-dong-biohub
marked this pull request as ready for review
July 30, 2026 21:05
uermel
approved these changes
Jul 31, 2026
uermel
left a comment
uermel
left a comment
Member
There was a problem hiding this comment.
Looks great as far as I can see, but one concern about the registry pathing.
| resolved = Path(path).resolve() | ||
| if not resolved.exists(): | ||
| raise FileNotFoundError(f"Local config not found: {resolved}") | ||
| pid = resolved.stem |
Member
There was a problem hiding this comment.
Using stem here has some potential for collisions I think?
e.g. when a user would run with two configs named config.json the stem would be the same even if they exist in different absolute paths.
copick-web /path/to/projectA/config.json /path/to/projectB/config.json
--> one project is overwritten by the other.
Might be safer to use a hash on the absolute path here?
Collaborator
Author
There was a problem hiding this comment.
yes, great catch. A hash would make sense, and i'll enhance where the displayed name could be the copick config's "name" rather than this id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes configuration and setup for multi-tenant.
Options include: local files (see .env.example), and/or pull projects from registry hosted on Embrella and stream tomograms. Streamed tomograms come from caddy-host or any file webserver to limit network proxying through the host.
Also includes: