feat(drive-integration): display validationFindings in mapping-review UI [INTEG-4383] #11087
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| import { cleanup, render, screen } from '@testing-library/react'; | ||
| import { afterEach, describe, expect, it, vi } from 'vitest'; | ||
| import type { ValidationFinding } from '@types'; | ||
| import type { EntryListRow } from '../../../../../src/utils/overviewEntryList'; | ||
| import { OverviewEntryList } from '../../../../../src/locations/Page/components/overview/OverviewEntryList'; | ||
|
|
||
| const makeRow = (entryIndex: number, label: string): EntryListRow => ({ | ||
| id: `row-${entryIndex}`, | ||
| entryIndex, | ||
| contentTypeName: 'Article', | ||
| entryTitle: label, | ||
| children: [], | ||
| }); | ||
|
|
||
| const renderList = ( | ||
| rows: EntryListRow[], | ||
| findingsByEntryIndex?: ReadonlyMap<number, ValidationFinding[]> | ||
| ) => | ||
| render( | ||
| <OverviewEntryList | ||
| rows={rows} | ||
| selectedEntryIndex={null} | ||
| selectedEntryKeys={new Set()} | ||
| onSelect={vi.fn()} | ||
| onToggleEntrySelection={vi.fn()} | ||
| findingsByEntryIndex={findingsByEntryIndex} | ||
| /> | ||
| ); | ||
|
|
||
| afterEach(() => cleanup()); | ||
|
|
||
| describe('OverviewEntryList — validation finding badges (INTEG-4383)', () => { | ||
| it('renders a "Needs attention" badge for entries with block findings', () => { | ||
| const rows = [makeRow(0, 'Entry A')]; | ||
| const findings: ValidationFinding[] = [ | ||
| { | ||
| code: 'required-field-missing', | ||
| message: 'title missing', | ||
| severity: 'block', | ||
| entryIndex: 0, | ||
| }, | ||
| ]; | ||
| renderList(rows, new Map([[0, findings]])); | ||
|
|
||
| expect(screen.getByText('Needs attention')).toBeTruthy(); | ||
| expect(screen.queryByText('Warning')).toBeNull(); | ||
| }); | ||
|
|
||
| it('renders a "Warning" badge for entries with only warn findings', () => { | ||
| const rows = [makeRow(0, 'Entry A')]; | ||
| const findings: ValidationFinding[] = [ | ||
| { code: 'displayField-blank', message: 'title blank', severity: 'warn', entryIndex: 0 }, | ||
| ]; | ||
| renderList(rows, new Map([[0, findings]])); | ||
|
|
||
| expect(screen.getByText('Warning')).toBeTruthy(); | ||
| expect(screen.queryByText('Needs attention')).toBeNull(); | ||
| }); | ||
|
|
||
| it('renders "Needs attention" (not Warning) when entry has both block and warn findings', () => { | ||
| const rows = [makeRow(0, 'Entry A')]; | ||
| const findings: ValidationFinding[] = [ | ||
| { | ||
| code: 'required-field-missing', | ||
| message: 'title missing', | ||
| severity: 'block', | ||
| entryIndex: 0, | ||
| }, | ||
| { code: 'displayField-blank', message: 'title blank', severity: 'warn', entryIndex: 0 }, | ||
| ]; | ||
| renderList(rows, new Map([[0, findings]])); | ||
|
|
||
| expect(screen.getByText('Needs attention')).toBeTruthy(); | ||
| expect(screen.queryByText('Warning')).toBeNull(); | ||
| }); | ||
|
|
||
| it('renders no finding badges when findingsByEntryIndex is undefined', () => { | ||
| const rows = [makeRow(0, 'Entry A')]; | ||
| renderList(rows, undefined); | ||
|
|
||
| expect(screen.queryByText('Needs attention')).toBeNull(); | ||
| expect(screen.queryByText('Warning')).toBeNull(); | ||
| }); | ||
|
|
||
| it('renders no finding badges for entries with no findings', () => { | ||
| const rows = [makeRow(0, 'Entry A'), makeRow(1, 'Entry B')]; | ||
| const findings: ValidationFinding[] = [ | ||
| { | ||
| code: 'required-field-missing', | ||
| message: 'title missing', | ||
| severity: 'block', | ||
| entryIndex: 1, | ||
| }, | ||
| ]; | ||
| renderList(rows, new Map([[1, findings]])); | ||
|
|
||
| // Only entry 1 should have the badge | ||
| expect(screen.getAllByText('Needs attention')).toHaveLength(1); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"No mapped content"and"Needs attention"/"Warning"are rendered as sibling<Badge>elements in a<Paragraph>. If an entry simultaneously has no mapped content type AND a block finding, both badges appear.Perhaps this is an expected behavior but since the PR didn't mention about this, just wanted to double check it with you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — this is intentional. An entry with no mapped content fields that also has a block finding (e.g. a required field is missing) would legitimately show both. The badges serve different purposes: "No mapped content" means none of the field mappings have any source refs, while "Needs attention" means the validate-payload step flagged a structural issue. They're not mutually exclusive so showing both makes sense here.