tests/runc-integration-skip.txt: document some skips - #2292
Merged
Merged
Conversation
giuseppe
approved these changes
Sep 30, 2026
giuseppe
left a comment
giuseppe
left a comment
Member
There was a problem hiding this comment.
LGTM, please merge once it is ready
kolyshkin
force-pushed
the
skip-list-comments
branch
7 times, most recently
from
October 1, 2026 19:03
2cf941a to
1bafde3
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Explain why some runc integration tests are skipped, grouping the entries which fail for the same reason: - the "container" sub-cgroup used with the systemd cgroup driver; - runc specific debug messages, output format and warnings; - errors worded differently; - rootless containers with resource limits and no cgroup permission. Also explain the seccomp -ENOSYS handling skip (to be solved in libseccomp) and the mount order skips (host rootfs paths used as mount destinations by the test, and idmapped mount sources inside the container rootfs). Separate the commented entries by empty lines, so that it is clear which entries a comment applies to, and move the entries with no explanation yet to the end. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
skip-list-comments
branch
from
October 1, 2026 19:13
1bafde3 to
61748ce
Compare
kolyshkin
marked this pull request as ready for review
October 1, 2026 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comments to
tests/runc-integration-skip.txtexplaining why some of the runc integration tests are skipped, and group the entries which fail for the same reason:containersub-cgroup of the unit cgroup, while the tests look at the unit cgroup itself (deletewith host pidns,delete --forcewith subcgroups,set cpu period with no quota);--debug exec,/proc/self/exe clone), thelistoutput format, and the "Such configuration is strongly discouraged" warning;kill detached busybox, memory policy with invalid arguments, seccomp hook and notify errors,scheduler vs cpus);Also document:
seccomp -ENOSYS handling: runc prepends a BPF stub to the seccomp filter which returns-ENOSYSfor syscalls with numbers larger than any syscall in the profile. crun does not do that; as it is a heuristic with known issues (see RFE: Reworking Seccomp Profiles to ENOSYS Default moby/moby#42871), it is better solved in libseccomp, see RFE: Add support for maximum supported kernel version seccomp/libseccomp#457;The commented entries are now separated by empty lines (a comment applies to the entries below it, up to the next empty line, as documented in the file header), and the entries with no explanation yet are moved to the end.