-
Notifications
You must be signed in to change notification settings - Fork 407
krun: implement support for passt networking #1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+203
−75
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d8813f3
.codespellrc: ignore passt
giuseppe 81c21e0
handlers: add new hook to close fds
slp 04c19ac
krun: process the vm configuration earlier
slp 23f7d9f
krun: consolidate configuration in configure_vm
slp 7c2500d
krun: ignore RAM configurations below 128MB
slp 8199cbb
krun: implement support for passt networking
slp acb904c
krun: Build passt argv based on nitro variant
tylerfanelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| [codespell] | ||
| skip = libocispec,build-aux,contrib,*.1,.git,configure,Makefile,libtool,m4,autom4te.cache,*.m4,*.mk | ||
| count = | ||
| ignore-words-list = ser | ||
| ignore-words-list = ser,passt |
Submodule libocispec
updated
9 files
| +78 −42 | .gitignore | |
| +8 −14 | Makefile.am | |
| +1 −1 | image-spec | |
| +1 −1 | runtime-spec | |
| +2 −2 | src/ocispec/generate.py | |
| +6 −6 | src/ocispec/headers.py | |
| +20 −8 | src/ocispec/helpers.py | |
| +2 −2 | src/ocispec/json_common.c | |
| +1,445 −2,337 | src/ocispec/sources.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the if statement condition evaluates to true, then no error is created.
I think using
crun_error_release (err);(in line 1656) requires that we know for sureerris equal toNULLor pointing to an allocated error. It's not clear at first sight whether that requirement is fulfilled.One idea is to replace line 897
with
and add
erras a function argument tolibkrun_close_fds()There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, fixed now.