imagebuildah.executor.getCreatedBy(): use digests for previous stages#6855
Open
nalind wants to merge 1 commit into
Open
imagebuildah.executor.getCreatedBy(): use digests for previous stages#6855nalind wants to merge 1 commit into
nalind wants to merge 1 commit into
Conversation
Instead of the previous stage's image ID, use the digest of that stage's manifest, as we would for other images that affect the effects of this instruction. Follows up on containers#6845. I'll mention the phrase "burst cache" here so that people searching for it in the commit log will find this and the reference to the previous patch when looking for related fixes. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
dosubot
Bot
added
the
size:XS
|
Ephemeral COPR build failed. @containers/packit-build please check. |
3 similar comments
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Instead of the previous stage's image ID, use the digest of that stage's manifest, as we would for other images that affect the effects of this instruction. Follows up on #6845. I'll mention the phrase "burst cache" here so that people searching for it in the commit log will find this and the reference to the previous patch when looking for related fixes.
How to verify it
New integration test based on the reproducer in #6845.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?